Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect locked models when switching languages #196

Closed
danielghost opened this issue Jul 19, 2023 · 1 comment · Fixed by #197
Closed

Incorrect locked models when switching languages #196

danielghost opened this issue Jul 19, 2023 · 1 comment · Fixed by #197
Assignees
@danielghost
Labels
bug released

Comments

@danielghost
Copy link
Contributor

danielghost commented Jul 19, 2023 •
edited
Loading

Subject of the issue/enhancement/features

A completed article can be relocked when switching languages or the course is reloaded, if a page contains more than one article, with trickle applied to the first article including "_onChildren": false.

As the trickle buttons are added before the completion state is restored for the course models, the article now expects the trickle button to be completed and therefore the article is restored in an incomplete state and is relocked.

Your environment

  • Framework 5.31.12
@danielghost danielghost self-assigned this Jul 19, 2023
danielghost added a commit that referenced this issue Jul 19, 2023
@danielghost
Fix: incorrect locked models when switching languages (fixes #196).
bc0fe7c
@danielghost danielghost mentioned this issue Jul 19, 2023
Merged
danielghost added a commit that referenced this issue Jul 20, 2023
@danielghost
Fix: wait for models state to be restored before adding trickle to re…
ca87b16 
…solve issues with models incorrectly unlocking/relocking across sessions (fixes #195, #196).
danielghost added a commit that referenced this issue Jul 21, 2023
@danielghost
Revert "Fix: incorrect locked models when switching languages (fixes #…
30cf889 
…196)."

This reverts commit bc0fe7c.
danielghost added a commit that referenced this issue Aug 30, 2023
@danielghost
Fix: restoration issues across sessions or when switching languages (#…
697f59c 
…197)

* Fix: wait for models state to be restored before adding trickle to resolve issues with models incorrectly unlocking/relocking across sessions (fixes #195, #196).

* Updated framework version dependency.
github-actions bot pushed a commit that referenced this issue Aug 30, 2023
@semantic-release-bot
Chore(release): 7.0.1 [skip ci]
9e31452 
## [7.0.1](v7.0.0...v7.0.1) (2023-08-30)

### Fix

* restoration issues across sessions or when switching languages (#197) ([697f59c](697f59c)), closes [#197](#197) [#195](#195) [#196](#196)
@github-actions
Copy link

🎉 This issue has been resolved in version 7.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
1 participant
@danielghost