Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trickle unlocking when switching languages #195

Closed
danielghost opened this issue Jul 14, 2023 · 3 comments
Closed

Trickle unlocking when switching languages #195

danielghost opened this issue Jul 14, 2023 · 3 comments
Assignees
@danielghost
Labels
bug released

Comments

@danielghost
Copy link
Contributor

Subject of the issue/enhancement/features

If the first block on a page is locked and incomplete when switching languages, all block for the new language are unlocked. The issue only seems to occur when all child components for the first block are incomplete.

Your environment

  • Framework 5.31.12 but also occurs in earlier versions
@danielghost danielghost self-assigned this Jul 17, 2023
danielghost added a commit that referenced this issue Jul 18, 2023
@danielghost
Fix: models unlocking when switching languages, if first block is inc…
95874fe 
…omplete (fixes #195).
@danielghost
Copy link
Contributor Author

danielghost commented Jul 18, 2023 •
edited
Loading

A side-effect of 95874fe is that the issue now also occurs if more than one article is used within the page and the course has an enabled _start location. This may require a fix to https://github.com/adaptlearning/adapt-contrib-core/blob/master/js/startController.js.

This was referenced Jul 19, 2023
Closed
Closed
danielghost added a commit that referenced this issue Jul 20, 2023
@danielghost
Fix: wait for models state to be restored before adding trickle to re…
ca87b16 
…solve issues with models incorrectly unlocking/relocking across sessions (fixes #195, #196).
@danielghost danielghost mentioned this issue Jul 20, 2023
Merged
@danielghost
Copy link
Contributor Author

Can't seem to replicate the initial issue when testing with a fresh 5.31.12 build. #195 (comment) is an issue but resolved in core. Closing ticket as these changes are incorporated in #197

danielghost added a commit that referenced this issue Aug 30, 2023
@danielghost
Fix: restoration issues across sessions or when switching languages (#…
697f59c 
…197)

* Fix: wait for models state to be restored before adding trickle to resolve issues with models incorrectly unlocking/relocking across sessions (fixes #195, #196).

* Updated framework version dependency.
github-actions bot pushed a commit that referenced this issue Aug 30, 2023
@semantic-release-bot
Chore(release): 7.0.1 [skip ci]
9e31452 
## [7.0.1](v7.0.0...v7.0.1) (2023-08-30)

### Fix

* restoration issues across sessions or when switching languages (#197) ([697f59c](697f59c)), closes [#197](#197) [#195](#195) [#196](#196)
@github-actions
Copy link

🎉 This issue has been resolved in version 7.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: models unlocking when switching languages adaptlearning/adapt-contrib-trickle
1 participant
@danielghost