Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assessment: _canShowMarking & _canShowModelAnswer settings not applied on restore #2693 #130

Merged
merged 4 commits into from
Apr 28, 2021
Merged

assessment: _canShowMarking & _canShowModelAnswer settings not applied on restore #2693 #130

merged 4 commits into from
Apr 28, 2021

Conversation

eleanor-heath
Copy link
Contributor

@eleanor-heath eleanor-heath self-assigned this Apr 6, 2021
oliverfoster
oliverfoster reviewed Apr 26, 2021
View reviewed changes
js/adapt-assessmentArticleModel.js Outdated Show resolved Hide resolved
js/adapt-assessmentArticleModel.js Outdated Show resolved Hide resolved
@oliverfoster oliverfoster removed the request for review from moloko April 28, 2021 13:58
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

ethan-lp
ethan-lp approved these changes Apr 28, 2021
View reviewed changes
Copy link

@ethan-lp ethan-lp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit ab8f7a7 into master Apr 28, 2021
@oliverfoster oliverfoster deleted the settings-not-applied-on-restore branch April 28, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@tomgreenfield tomgreenfield Awaiting requested review from tomgreenfield

Assignees

@eleanor-heath eleanor-heath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eleanor-heath @oliverfoster @cahirodoherty-learningpool @ethan-lp