assessment: _canShowMarking & _canShowModelAnswer settings not applied on restore

[moloko]

Subject of the issue/enhancement/features

The _canShowMarking & _canShowModelAnswer settings in _assessment._questions are not being set on the assessment questions for restored, completed, assessments.

(quite possibly the _canShowFeedback setting too, I just didn't have time to test this)

Your environment

• FW v5.2.0, Assessment v4.0.0 (may be present in earlier versions, I haven't tested)
• any browser/device/OS
• device(s) + operating system(s)

Steps to reproduce

In the assessment config, set _questions._canShowMarking & _questions._canShowModelAnswer to false.

Also set _attempts to 1 and both _allowResetIfPassed & _isResetOnRevisit to false

For all the questions in the assessment, set _canShowMarking and _canShowModelAnswer to true (or just delete these settings from the JSON - they both default to true in the code anyway).

Set _shouldStoreResponses to true in the spoor config.

Finally, either run grunt server-scorm or launch the course from an LMS.

Partially complete the assessment. Quit and relaunch. Note how both marking and model answer are OFF i.e. the settings on the assessment are overriding the settings on the questions.

Now complete the assessment. Doesn't matter if you pass or fail. Quit and relaunch. Note how marking and model answer are now enabled.

Expected behaviour

The settings at the assessment level should continue to override the settings at question level.

Actual behaviour

The settings at question level take precedence.

Screenshots (if you can)

After partial completion, quit and relaunch:

After completing, quit and relaunch: