Twenty twenty-four: fixed contrast issues, improved documentations, general polishing before release #5623

MaggieCabrera · 2023-11-06T11:24:44Z

Trac ticket: https://core.trac.wordpress.org/ticket/59812

This PR includes the last fixes to the theme before the release:

WordPress/twentytwentyfour#723
WordPress/twentytwentyfour#718
WordPress/twentytwentyfour#719
WordPress/twentytwentyfour#720
WordPress/twentytwentyfour#722

Addresses some issues with contrast on some of the theme variations, we ended up removing a color that is no longer used from the theme and variations.
Fixes an issue with a pattern that was using the wrong unit type for the min-height.
Moves wp_enqueue_block_style call to its own function for clarity.
Updates the link to the docs on the changelog

Props:

onemaggie, richtabor, luminuu, huzaifaalmesbah, sabernhardt, poena

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Removed queryId

hellofromtonya · 2023-11-06T13:56:28Z

src/wp-content/themes/twentytwentyfour/theme.json

@@ -785,7 +780,6 @@
 			"background": "var(--wp--preset--color--base)",
 			"text": "var(--wp--preset--color--contrast)"
 		},
-		"css": "a{text-decoration-thickness:0.0625em;text-underline-offset: 0.15em}",


Change from WordPress/twentytwentyfour#723 ✅

hellofromtonya · 2023-11-06T13:57:02Z

src/wp-content/themes/twentytwentyfour/readme.txt

@@ -16,7 +16,7 @@ Twenty Twenty-Four is designed to be flexible, versatile and applicable to any w
 = 1.0 =
 * Released: November 7, 2023

-https://wordpress.org/support/article/twenty-twenty-four-changelog#Version_1.0
+https://wordpress.org/documentation/article/twenty-twenty-four-changelog/#Version_1.0


Change from WordPress/twentytwentyfour#718 ✅

hellofromtonya · 2023-11-06T13:58:07Z

src/wp-content/themes/twentytwentyfour/functions.php

@@ -164,6 +146,40 @@ function twentytwentyfour_block_styles() {

 add_action( 'init', 'twentytwentyfour_block_styles' );

+/**


Change from WordPress/twentytwentyfour#719 ✅

hellofromtonya · 2023-11-06T13:58:42Z

src/wp-content/themes/twentytwentyfour/patterns/page-newsletter-landing.php

@@ -10,8 +10,8 @@
 */
 ?>

-<!-- wp:group {"align":"full","style":{"spacing":{"padding":{"right":"var:preset|spacing|50","left":"var:preset|spacing|50","top":"var:preset|spacing|60","bottom":"var:preset|spacing|60"},"margin":{"top":"0","bottom":"0"}},"dimensions":{"minHeight":"100vw"}},"backgroundColor":"accent-3","layout":{"type":"flex","orientation":"vertical","justifyContent":"center","verticalAlignment":"center"}} -->
-<div class="wp-block-group alignfull has-accent-3-background-color has-background" style="min-height:100vw;margin-top:0;margin-bottom:0;padding-top:var(--wp--preset--spacing--60);padding-right:var(--wp--preset--spacing--50);padding-bottom:var(--wp--preset--spacing--60);padding-left:var(--wp--preset--spacing--50)">
+<!-- wp:group {"align":"full","style":{"spacing":{"padding":{"right":"var:preset|spacing|50","left":"var:preset|spacing|50","top":"var:preset|spacing|60","bottom":"var:preset|spacing|60"},"margin":{"top":"0","bottom":"0"}},"dimensions":{"minHeight":"100vh"}},"backgroundColor":"accent-3","layout":{"type":"flex","orientation":"vertical","justifyContent":"center","verticalAlignment":"center"}} -->


Changes from WordPress/twentytwentyfour#720 ✅

hellofromtonya · 2023-11-06T14:00:24Z

src/wp-content/themes/twentytwentyfour/functions.php

@@ -50,7 +33,6 @@ function twentytwentyfour_block_styles() {
 				.is-style-arrow-icon-details {
 					padding-top: var(--wp--preset--spacing--10);
 					padding-bottom: var(--wp--preset--spacing--10);
-					border-bottom: 1px solid var(--wp--preset--color--contrast-2, currentColor);


Change from WordPress/twentytwentyfour#722 ✅

hellofromtonya · 2023-11-06T14:01:28Z

src/wp-content/themes/twentytwentyfour/patterns/cta-pricing.php

@@ -29,8 +29,8 @@

 		<!-- wp:columns {"align":"wide","style":{"spacing":{"blockGap":{"top":"var:preset|spacing|50","left":"var:preset|spacing|20"}}}} -->
 		<div class="wp-block-columns alignwide">
-			<!-- wp:column {"style":{"spacing":{"padding":{"right":"var:preset|spacing|30","left":"var:preset|spacing|30","top":"var:preset|spacing|30","bottom":"var:preset|spacing|10"}},"border":{"top":{"color":"var:preset|color|base-3","width":"1px"}}}} -->
-			<div class="wp-block-column" style="border-top-color:var(--wp--preset--color--base-3);border-top-width:1px;padding-top:var(--wp--preset--spacing--30);padding-right:var(--wp--preset--spacing--30);padding-bottom:var(--wp--preset--spacing--10);padding-left:var(--wp--preset--spacing--30)">
+			<!-- wp:column {"style":{"spacing":{"padding":{"right":"var:preset|spacing|30","left":"var:preset|spacing|30","top":"var:preset|spacing|30","bottom":"var:preset|spacing|10"}},"border":{"top":{"color":"var:preset|color|contrast-3","width":"1px"}}}} -->


Changes from Change from WordPress/twentytwentyfour#722 ✅

hellofromtonya · 2023-11-06T14:01:50Z

src/wp-content/themes/twentytwentyfour/patterns/hidden-sidebar.php

@@ -23,8 +23,8 @@
 	</div>
 	<!-- /wp:group -->

-	<!-- wp:separator {"backgroundColor":"base-3","className":"is-style-wide"} -->
-	<hr class="wp-block-separator has-text-color has-base-3-color has-alpha-channel-opacity has-base-3-background-color has-background is-style-wide" />
+	<!-- wp:separator {"backgroundColor":"contrast","className":"is-style-wide"} -->


Change from WordPress/twentytwentyfour#722 ✅

hellofromtonya · 2023-11-06T14:02:18Z

src/wp-content/themes/twentytwentyfour/patterns/text-faq.php

@@ -16,39 +16,39 @@

 	<!-- wp:group {"align":"wide","layout":{"type":"default"}} -->
 	<div class="wp-block-group alignwide">
-		<!-- wp:separator {"backgroundColor":"contrast-2","className":"is-style-wide"} -->
-		<hr class="wp-block-separator has-text-color has-contrast-2-color has-alpha-channel-opacity has-contrast-2-background-color has-background is-style-wide"/>
+		<!-- wp:separator {"backgroundColor":"base","className":"is-style-wide"} -->


Change from WordPress/twentytwentyfour#722 ✅

hellofromtonya · 2023-11-06T14:02:43Z

src/wp-content/themes/twentytwentyfour/styles/ember.json

@@ -96,11 +96,6 @@
 					"color": "#f6decd",
 					"name": "Base / Two",
 					"slug": "base-2"
-				},


Change from WordPress/twentytwentyfour#722 ✅

hellofromtonya · 2023-11-06T14:02:56Z

src/wp-content/themes/twentytwentyfour/styles/fossil.json

@@ -77,11 +77,6 @@
 					"name": "Base / Two",
 					"slug": "base-2"
 				},
-				{


Change from WordPress/twentytwentyfour#722 ✅

hellofromtonya · 2023-11-06T14:03:14Z

src/wp-content/themes/twentytwentyfour/styles/ice.json

@@ -77,11 +77,6 @@
 					"name": "Base / Two",
 					"slug": "base-2"
 				},
-				{


Change from WordPress/twentytwentyfour#722 ✅

hellofromtonya · 2023-11-06T14:03:30Z

src/wp-content/themes/twentytwentyfour/styles/maelstrom.json

@@ -15,11 +15,6 @@
 					"name": "Base / Two",
 					"slug": "base-2"
 				},
-				{


Change from WordPress/twentytwentyfour#722 ✅

hellofromtonya · 2023-11-06T14:03:35Z

src/wp-content/themes/twentytwentyfour/styles/mint.json

@@ -15,11 +15,6 @@
 					"name": "Base / Two",
 					"slug": "base-2"
 				},
-				{


Change from WordPress/twentytwentyfour#722 ✅

hellofromtonya · 2023-11-06T14:03:43Z

src/wp-content/themes/twentytwentyfour/styles/onyx.json

@@ -119,11 +119,6 @@
 					"name": "Base / Two",
 					"slug": "base-2"
 				},
-				{
-					"color": "#ffffff26",


Change from WordPress/twentytwentyfour#722 ✅

hellofromtonya · 2023-11-06T14:04:00Z

src/wp-content/themes/twentytwentyfour/templates/single.html

@@ -31,8 +31,8 @@
 			</div>
 			<!-- /wp:spacer -->

-			<!-- wp:separator {"style":{"spacing":{"margin":{"bottom":"var:preset|spacing|40"}}},"backgroundColor":"base-3","className":"is-style-wide"} -->
-			<hr class="wp-block-separator has-text-color has-base-3-color has-alpha-channel-opacity has-base-3-background-color has-background is-style-wide" style="margin-bottom:var(--wp--preset--spacing--40)"/>
+			<!-- wp:separator {"style":{"spacing":{"margin":{"bottom":"var:preset|spacing|40"}}},"backgroundColor":"contrast-3","className":"is-style-wide"} -->


Change from WordPress/twentytwentyfour#722 ✅

hellofromtonya · 2023-11-06T14:04:12Z

src/wp-content/themes/twentytwentyfour/theme.json

@@ -111,11 +111,6 @@
 					"name": "Base / Two",
 					"slug": "base-2"
 				},
-				{


Change from WordPress/twentytwentyfour#722 ✅

hellofromtonya · 2023-11-06T14:11:46Z

Confirmed changes are ported to this PR ✅

Next step: Test the PR to ensure the theme loads and renders without errors.

hellofromtonya

Ready for commit 👍

Includes the recent changes since RC3 ✅
Renders properly without errors ✅
Has a test report to confirm the changes work ✅

hellofromtonya · 2023-11-06T14:44:23Z

Committed to trunk via https://core.trac.wordpress.org/changeset/57067.

MaggieCabrera added 2 commits November 6, 2023 12:23

fixed contrast issues, cleaned up functions and docs

e8f811d

Update posts-list.php

23f6916

Removed queryId

sabernhardt mentioned this pull request Nov 6, 2023

Update bundled theme versions released with WordPress 6.4 #5601

Closed

hellofromtonya self-requested a review November 6, 2023 13:39

hellofromtonya reviewed Nov 6, 2023

View reviewed changes

hellofromtonya approved these changes Nov 6, 2023

View reviewed changes

hellofromtonya closed this Nov 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Twenty twenty-four: fixed contrast issues, improved documentations, general polishing before release #5623

Twenty twenty-four: fixed contrast issues, improved documentations, general polishing before release #5623

MaggieCabrera commented Nov 6, 2023 •

edited

Loading

hellofromtonya Nov 6, 2023

hellofromtonya Nov 6, 2023

hellofromtonya Nov 6, 2023

hellofromtonya Nov 6, 2023

hellofromtonya Nov 6, 2023

hellofromtonya Nov 6, 2023

hellofromtonya Nov 6, 2023

hellofromtonya Nov 6, 2023

hellofromtonya Nov 6, 2023

hellofromtonya Nov 6, 2023

hellofromtonya Nov 6, 2023

hellofromtonya Nov 6, 2023

hellofromtonya Nov 6, 2023

hellofromtonya Nov 6, 2023

hellofromtonya Nov 6, 2023

hellofromtonya Nov 6, 2023

hellofromtonya commented Nov 6, 2023

hellofromtonya left a comment

hellofromtonya commented Nov 6, 2023

		@@ -164,6 +146,40 @@ function twentytwentyfour_block_styles() {

		add_action( 'init', 'twentytwentyfour_block_styles' );

		/**

Twenty twenty-four: fixed contrast issues, improved documentations, general polishing before release #5623

Twenty twenty-four: fixed contrast issues, improved documentations, general polishing before release #5623

Conversation

MaggieCabrera commented Nov 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hellofromtonya commented Nov 6, 2023

hellofromtonya left a comment

Choose a reason for hiding this comment

hellofromtonya commented Nov 6, 2023

MaggieCabrera commented Nov 6, 2023 •

edited

Loading