Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Separate outline css to its own function #719

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Separate outline css to its own function #719

merged 2 commits into from
Nov 6, 2023

Conversation

MaggieCabrera
Copy link
Collaborator

@MaggieCabrera MaggieCabrera commented Nov 3, 2023

Description

While presenting the theme yesterday during developer hours I noticed that we are putting on the same function the registering of block styles and the enqueueing of the stylesheet for the outline block style. While the end result is similar in nature, I think it can be confusing for users that want to learn from TT4, so they are best separated into two different functions.

@huzaifaalmesbah
Copy link
Collaborator

I agree with that looks good. It will be helpful to understand.

Copy link
Member

@luminuu luminuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luminuu luminuu merged commit 6d13887 into trunk Nov 6, 2023
2 checks passed
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Nov 6, 2023
This update includes the following changes:

* [WordPress/twentytwentyfour#723 Remove custom CSS for links].
* [WordPress/twentytwentyfour#718 Fix the link to the theme's docs].
* [WordPress/twentytwentyfour#719 Separate outline css to its own function] - which introduces `twentytwentyfour_block_stylesheets()` for enqueuing custom block stylesheets.
* [WordPress/twentytwentyfour#720 Fix height of newsletter landing pattern].
* [WordPress/twentytwentyfour#722 Resolve border colors in variations].

Follow up to [57036], [56999], [56951], [56813], [56764], [56716].

Props onemaggie, richtabor, luminuu, huzaifaalmesbah, sabernhardt, poena, rajinsharwar.
Fixes #59812.
Built from https://develop.svn.wordpress.org/trunk@57067


git-svn-id: http://core.svn.wordpress.org/trunk@56578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to gilzow/wordpress-performance that referenced this pull request Nov 6, 2023
This update includes the following changes:

* [WordPress/twentytwentyfour#723 Remove custom CSS for links].
* [WordPress/twentytwentyfour#718 Fix the link to the theme's docs].
* [WordPress/twentytwentyfour#719 Separate outline css to its own function] - which introduces `twentytwentyfour_block_stylesheets()` for enqueuing custom block stylesheets.
* [WordPress/twentytwentyfour#720 Fix height of newsletter landing pattern].
* [WordPress/twentytwentyfour#722 Resolve border colors in variations].

Follow up to [57036], [56999], [56951], [56813], [56764], [56716].

Props onemaggie, richtabor, luminuu, huzaifaalmesbah, sabernhardt, poena, rajinsharwar.
Fixes #59812.
Built from https://develop.svn.wordpress.org/trunk@57067


git-svn-id: https://core.svn.wordpress.org/trunk@56578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Nov 6, 2023
This update includes the following changes:

* [WordPress/twentytwentyfour#723 Remove custom CSS for links].
* [WordPress/twentytwentyfour#718 Fix the link to the theme's docs].
* [WordPress/twentytwentyfour#719 Separate outline css to its own function] - which introduces `twentytwentyfour_block_stylesheets()` for enqueuing custom block stylesheets.
* [WordPress/twentytwentyfour#720 Fix height of newsletter landing pattern].
* [WordPress/twentytwentyfour#722 Resolve border colors in variations].

Follow up to [57036], [56999], [56951], [56813], [56764], [56716].

Reviewed by desrosj.
Merges [57067] to the 6.4 branch.

Props onemaggie, richtabor, luminuu, huzaifaalmesbah, sabernhardt, poena, rajinsharwar.
Fixes #59812.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57070 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Nov 6, 2023
This update includes the following changes:

* [WordPress/twentytwentyfour#723 Remove custom CSS for links].
* [WordPress/twentytwentyfour#718 Fix the link to the theme's docs].
* [WordPress/twentytwentyfour#719 Separate outline css to its own function] - which introduces `twentytwentyfour_block_stylesheets()` for enqueuing custom block stylesheets.
* [WordPress/twentytwentyfour#720 Fix height of newsletter landing pattern].
* [WordPress/twentytwentyfour#722 Resolve border colors in variations].

Follow up to [57036], [56999], [56951], [56813], [56764], [56716].

Reviewed by desrosj.
Merges [57067] to the 6.4 branch.

Props onemaggie, richtabor, luminuu, huzaifaalmesbah, sabernhardt, poena, rajinsharwar.
Fixes #59812.
Built from https://develop.svn.wordpress.org/branches/6.4@57070


git-svn-id: http://core.svn.wordpress.org/branches/6.4@56581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants