Data: Fix wp.data.query backwards compatibility with props #5220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
aduth
commented
Feb 23, 2018
data/test/index.js
Outdated
| registerReducer( 'reactReducer', () => ( { reactKey: 'reactState' } ) ); | ||
| registerSelectors( 'reactReducer', { | ||
| reactSelector: ( state, key ) => state[ key ], | ||
| function cases( withSelectImpl, extraAssertions = noop ) { |
There was a problem hiding this comment.
None of the tests themselves have changed, just putting in a function to allow testing both withSelect and query separately with same expectations (except console.warn in the latter).
There was a problem hiding this comment.
The function name is unclear to me :)
There was a problem hiding this comment.
The function name is unclear to me :)
I broke my own rule of no abbreviations 😄 It's a semi-common convention for "Implementation". I've unabbreviated it.
1 task
aduth
force-pushed
the
fix/query-deprecated
branch
from
66fdda5
to
9e5ccd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5137
This pull request seeks to resolve an issue where the
wp.data.querybackwards-compatibility added with the introduction ofwp.data.withSelectdoes not correctly pass props. In the course of revisions to #5137, it was overlooked to use the final signature of( select, props )onwithSelect. No errors occurred only because none of the core components had used theownPropsargument of thequeryhigher-order component.Testing instructions:
Ensure unit tests pass:
As of #5215, no core components use
wp.data.query, so this cannot be easily tested in the browser without manual changes.