Data: Refactor query HOC usage with withSelect #5215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
the
[Feature] UI Components
gziolo
commented
Feb 23, 2018
| @@ -47,7 +47,7 @@ const SidebarHeader = ( { panel, onSetPanel, onCloseSidebar, count } ) => { | |||
| }; | |||
|
|
|||
| export default compose( | |||
| query( ( select ) => ( { | |||
| withSelect( ( select ) => ( { | |||
| count: select( 'core/editor' ).getSelectedBlockCount(), | |||
| } ) ), | |||
There was a problem hiding this comment.
connect should go next as soon as we expose all selectors and actions :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a few deprecations warnings on the JS console coming from
queryHOC. This PR refactors all code occurrences to use newwithSelectHOC.How Has This Been Tested?
Make sure there are no warnings on the JS console and there are no regressions.
Checklist: