Mark related selector as resolved when sideloading Navigation fallback #50324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
changed the title
getdave
changed the title
|
Size Change: +23 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
scruffian
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Mark resolvers relating to queries for retrieved Navigation fallback as "resolved" to avoid further network requests.
Closes #50322
Why?
Following work done in #50032 it was still sometimes possible (race condition?) to see network requests dispatched from calls to
getEntityRecordafter the navigation fallback had already been added to Core Data state.Speaking with @youknowriad it is my understanding that whilst we are sideloading the record into state, we are not marking the related resolver as being "resolved". This means calls which trigger that resolver may still dispatch network requests to
wp/v2/navigation/{{FALLBACK_ID}}when this record has already been sideloaded into state as the result of the originalgetNavigationFallbackIdcall.How?
We manually resolve the selector using:
Testing Instructions
Headersfallback- see a single request onlynavigationOPTIONSrequest to/wp-json/wp/v2/navigation/{{FALLBACK_ID}}GETrequests to/wp-json/wp/v2/navigation/{{FALLBACK_ID}}Testing Instructions for Keyboard
Screenshots or screencast