Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark queries relating to Nav fallback as resolved to avoid network fetches #50322

Closed
getdave opened this issue May 4, 2023 · 0 comments · Fixed by #50324
Closed

Mark queries relating to Nav fallback as resolved to avoid network fetches #50322

getdave opened this issue May 4, 2023 · 0 comments · Fixed by #50324
Assignees
Labels
[Block] Navigation Affects the Navigation Block

Comments

@getdave
Copy link
Contributor

getdave commented May 4, 2023

Essentially we need to update the work done here so that when we sideload the entity into state we also mark any resolvers as "done" with finishResolution.


@youknowriad I am still sometimes seeing the getEntityRecord (singular) for the Post being triggered even though the entity has already been sideloaded into Core Data state.

Do you think I ought to call...

dispatch.finishResolution( 'getEntityRecord', [
	'postType',
	'wp_navigation',
	fallback?.id,
] );

...here to mark the query as resolved?

Originally posted by @getdave in #50032 (comment)

@getdave getdave self-assigned this May 4, 2023
@getdave getdave added the [Block] Navigation Affects the Navigation Block label May 4, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 4, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants