Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: Improve BoxControl tests #45968

Merged
merged 12 commits into from
Nov 29, 2022
Merged

Components: Improve BoxControl tests #45968

merged 12 commits into from
Nov 29, 2022

Commits on Nov 23, 2022

  1. Fix no-node-access violation

    @tyxla
    tyxla committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    98bfb2b View commit details
    Browse the repository at this point in the history

  2. Get rid of getInput() and improve input query

    @tyxla
    tyxla committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    26658f2 View commit details
    Browse the repository at this point in the history

  3. Get rid of getSelect() and improve combobox query

    @tyxla
    tyxla committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    29c56f0 View commit details
    Browse the repository at this point in the history

  4. Get rid of getReset() and improve reset button query

    @tyxla
    tyxla committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    df5753f View commit details
    Browse the repository at this point in the history

  5. Get rid of setupUser() and inline it

    @tyxla
    tyxla committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    54f8036 View commit details
    Browse the repository at this point in the history

  6. Add spaces to improve readability

    @tyxla
    tyxla committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    95c25d3 View commit details
    Browse the repository at this point in the history

  7. Improve test name

    @tyxla
    tyxla committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    b44098c View commit details
    Browse the repository at this point in the history

  8. Inline all constants that are used just once

    @tyxla
    tyxla committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    5ee14cc View commit details
    Browse the repository at this point in the history

  9. Use toHaveLength to improve assertion

    @tyxla
    tyxla committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    fe59021 View commit details
    Browse the repository at this point in the history

  10. Revert unwanted change

    @tyxla
    tyxla committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    27ed32c View commit details
    Browse the repository at this point in the history

  11. Improve precision of existing queries

    @tyxla
    tyxla committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    7f379b7 View commit details
    Browse the repository at this point in the history

  12. Use the same mock for setState(), improve assertions

    @tyxla
    tyxla committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    df405ba View commit details
    Browse the repository at this point in the history