Components: Improve BoxControl tests
#45968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Code Quality
tyxla
requested review from
Mamaduka,
mirka,
jsnajdr,
ciampo,
flootr,
chad1008,
ntsekouras and
brookewp
|
|
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
Mamaduka
reviewed
Nov 23, 2022
|
Note that the failing check is not related to this PR and I've filed a fix for it in #45999. |
tyxla
force-pushed
the
improve/box-control-tests
branch
from
c3f0a37
to
df405ba
Compare
Mamaduka
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is improving the existing tests of the
BoxControlcomponent. Easiest to review commit-by-commit.Why?
My initial motivation was to just address a few pre-existing
no-node-accessESLint violations but ended up fixing a few other issues that make the tests ultimately more readable and reliable.How?
We're basically doing a few improvements, which I've tried to keep in separate commits:
no-node-accessviolation by using ascreen.getByRole()query.getInput()helper and improve input query.getSelect()helper and improve the combobox query.getReset()helper and improve reset button query.setupUser()and inline its calls..toHaveLength()instead ofx.length.toBe()getByRole()instead of the less-specific queries.Testing Instructions
Verify tests still pass.