Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Letter spacing: update label copy #36385

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Letter spacing: update label copy #36385

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2d5b6c
Overwrite default component view label styles so that the Typography …
ramonjd Nov 10, 2021
5f7626d
Rolling back margin changes since they'll be fixed in https://github.…
ramonjd Nov 11, 2021
a0e8ad5
Remove classname
ramonjd Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/block-editor/src/components/letter-spacing-control/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ export default function LetterSpacingControl( {
} );
return (
<UnitControl
label={ __( 'Letter-spacing' ) }
className="block-editor-letter-spacing-control"
ramonjd marked this conversation as resolved.
Show resolved Hide resolved
label={ __( 'Letter spacing' ) }
value={ value }
__unstableInputWidth={ __unstableInputWidth }
units={ units }
Expand Down
2 changes: 1 addition & 1 deletion packages/block-editor/src/hooks/typography.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ export function TypographyPanel( props ) {
<ToolsPanelItem
className="single-column"
hasValue={ () => hasLetterSpacingValue( props ) }
label={ __( 'Letter-spacing' ) }
label={ __( 'Letter spacing' ) }
onDeselect={ () => resetLetterSpacing( props ) }
isShownByDefault={ defaultControls?.letterSpacing }
resetAllFilter={ createResetAllFilter( 'letterSpacing' ) }
Expand Down
6 changes: 3 additions & 3 deletions packages/block-editor/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@
@import "./components/default-block-appender/style.scss";
@import "./components/duotone-control/style.scss";
@import "./components/font-appearance-control/style.scss";
@import "./components/justify-content-control/style.scss";
@import "./components/link-control/style.scss";
@import "./components/line-height-control/style.scss";
@import "./components/image-size-control/style.scss";
@import "./components/inner-blocks/style.scss";
@import "./components/inserter-list-item/style.scss";
@import "./components/justify-content-control/style.scss";
@import "./components/line-height-control/style.scss";
@import "./components/link-control/style.scss";
@import "./components/list-view/style.scss";
@import "./components/media-replace-flow/style.scss";
@import "./components/media-placeholder/style.scss";
Expand Down