Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter spacing: update label copy #36385

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Letter spacing: update label copy #36385

merged 3 commits into from
Nov 16, 2021

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Nov 10, 2021

Description

This PR:

Before After
Screen Shot 2021-11-11 at 9 37 31 am Screen Shot 2021-11-11 at 9 23 19 am

Testing

Insert a core text block – the paragraph block is an excellent choice. Select your block.

In the Typography Tools Panel in the right-hand sidebar, add a Letter spacing control.

The label margins should match and the label, for the Tools Panel options drop down and for the control itself should read 'Letter spacing', without the hyphen.

Types of changes

Copy

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

…control labels are uniform

Organize imports alphabetically
Remove hyphen from label
@ramonjd ramonjd added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Nov 10, 2021
@github-actions
Copy link

github-actions bot commented Nov 10, 2021

Size Change: +7.4 kB (+1%)

Total Size: 1.09 MB

Filename Size Change
build/a11y/index.min.js 960 B +29 B (+3%)
build/admin-manifest/index.min.js 1.1 kB +5 B (0%)
build/annotations/index.min.js 2.75 kB +49 B (+2%)
build/api-fetch/index.min.js 2.21 kB +38 B (+2%)
build/autop/index.min.js 2.12 kB +40 B (+2%)
build/block-directory/index.min.js 6.28 kB +76 B (+1%)
build/block-editor/index.min.js 139 kB +1.25 kB (+1%)
build/block-editor/style-rtl.css 14.4 kB +20 B (0%)
build/block-editor/style.css 14.4 kB +16 B (0%)
build/block-library/blocks/buttons/editor-rtl.css 291 B -1 B (0%)
build/block-library/blocks/buttons/editor.css 291 B -1 B (0%)
build/block-library/blocks/code/theme-rtl.css 134 B +3 B (+2%)
build/block-library/blocks/code/theme.css 134 B +3 B (+2%)
build/block-library/blocks/cover/style-rtl.css 1.18 kB +2 B (0%)
build/block-library/blocks/cover/style.css 1.18 kB +2 B (0%)
build/block-library/blocks/gallery/style-rtl.css 1.62 kB +21 B (+1%)
build/block-library/blocks/gallery/style.css 1.62 kB +22 B (+1%)
build/block-library/blocks/navigation/editor-rtl.css 1.89 kB -50 B (-3%)
build/block-library/blocks/navigation/editor.css 1.89 kB -48 B (-2%)
build/block-library/blocks/navigation/style-rtl.css 1.55 kB +23 B (+2%)
build/block-library/blocks/navigation/style.css 1.54 kB +28 B (+2%)
build/block-library/blocks/post-comments-form/style-rtl.css 444 B +97 B (+28%) 🚨
build/block-library/blocks/post-comments-form/style.css 444 B +97 B (+28%) 🚨
build/block-library/blocks/post-title/style-rtl.css 80 B +20 B (+33%) 🚨
build/block-library/blocks/post-title/style.css 80 B +20 B (+33%) 🚨
build/block-library/blocks/video/editor-rtl.css 569 B -2 B (0%)
build/block-library/blocks/video/editor.css 570 B -2 B (0%)
build/block-library/editor-rtl.css 9.84 kB -46 B (0%)
build/block-library/editor.css 9.85 kB -48 B (0%)
build/block-library/index.min.js 161 kB +936 B (+1%)
build/block-library/style-rtl.css 10.5 kB +143 B (+1%)
build/block-library/style.css 10.5 kB +156 B (+2%)
build/block-library/theme-rtl.css 672 B +4 B (+1%)
build/block-library/theme.css 677 B +4 B (+1%)
build/blocks/index.min.js 46.3 kB +254 B (+1%)
build/components/index.min.js 214 kB +923 B (0%)
build/components/style-rtl.css 15.3 kB +3 B (0%)
build/components/style.css 15.3 kB +3 B (0%)
build/compose/index.min.js 10.9 kB +69 B (+1%)
build/core-data/index.min.js 13.2 kB +391 B (+3%)
build/customize-widgets/index.min.js 11.4 kB +129 B (+1%)
build/data-controls/index.min.js 631 B +17 B (+3%)
build/data/index.min.js 7.42 kB +266 B (+4%)
build/date/index.min.js 31.5 kB +18 B (0%)
build/deprecated/index.min.js 485 B +57 B (+13%) ⚠️
build/dom/index.min.js 4.5 kB +54 B (+1%)
build/edit-navigation/index.min.js 16 kB +179 B (+1%)
build/edit-post/index.min.js 29.6 kB +177 B (+1%)
build/edit-post/style-rtl.css 7.1 kB -25 B (0%)
build/edit-post/style.css 7.09 kB -25 B (0%)
build/edit-site/index.min.js 28.3 kB +249 B (+1%)
build/edit-site/style-rtl.css 5.37 kB +48 B (+1%)
build/edit-site/style.css 5.37 kB +50 B (+1%)
build/edit-widgets/index.min.js 16.5 kB +122 B (+1%)
build/edit-widgets/style-rtl.css 4.18 kB +2 B (0%)
build/editor/index.min.js 37.8 kB +348 B (+1%)
build/element/index.min.js 3.29 kB +83 B (+3%)
build/format-library/index.min.js 6.57 kB +80 B (+1%)
build/hooks/index.min.js 1.63 kB +80 B (+5%) 🔍
build/i18n/index.min.js 3.71 kB +107 B (+3%)
build/keyboard-shortcuts/index.min.js 1.8 kB +73 B (+4%)
build/keycodes/index.min.js 1.39 kB +83 B (+6%) 🔍
build/list-reusable-blocks/index.min.js 1.86 kB +9 B (0%)
build/media-utils/index.min.js 2.92 kB +3 B (0%)
build/notices/index.min.js 925 B +80 B (+9%) 🔍
build/nux/index.min.js 2.08 kB +51 B (+3%)
build/plugins/index.min.js 1.84 kB +13 B (+1%)
build/primitives/index.min.js 924 B +3 B (0%)
build/redux-routine/index.min.js 2.65 kB +22 B (+1%)
build/reusable-blocks/index.min.js 2.22 kB +33 B (+2%)
build/rich-text/index.min.js 11 kB +188 B (+2%)
build/server-side-render/index.min.js 1.57 kB +43 B (+3%)
build/shortcode/index.min.js 1.49 kB +13 B (+1%)
build/token-list/index.min.js 639 B +77 B (+14%) ⚠️
build/url/index.min.js 1.9 kB +74 B (+4%)
build/viewport/index.min.js 1.05 kB +33 B (+3%)
build/widgets/index.min.js 7.15 kB +40 B (+1%)
ℹ️ View Unchanged
Filename Size
build/blob/index.min.js 459 B
build/block-directory/style-rtl.css 1.01 kB
build/block-directory/style.css 1.01 kB
build/block-editor/default-editor-styles-rtl.css 378 B
build/block-editor/default-editor-styles.css 378 B
build/block-library/blocks/archives/editor-rtl.css 61 B
build/block-library/blocks/archives/editor.css 60 B
build/block-library/blocks/archives/style-rtl.css 65 B
build/block-library/blocks/archives/style.css 65 B
build/block-library/blocks/audio/editor-rtl.css 58 B
build/block-library/blocks/audio/editor.css 58 B
build/block-library/blocks/audio/style-rtl.css 111 B
build/block-library/blocks/audio/style.css 111 B
build/block-library/blocks/audio/theme-rtl.css 125 B
build/block-library/blocks/audio/theme.css 125 B
build/block-library/blocks/block/editor-rtl.css 161 B
build/block-library/blocks/block/editor.css 161 B
build/block-library/blocks/button/editor-rtl.css 470 B
build/block-library/blocks/button/editor.css 470 B
build/block-library/blocks/button/style-rtl.css 560 B
build/block-library/blocks/button/style.css 560 B
build/block-library/blocks/buttons/style-rtl.css 275 B
build/block-library/blocks/buttons/style.css 275 B
build/block-library/blocks/calendar/style-rtl.css 207 B
build/block-library/blocks/calendar/style.css 207 B
build/block-library/blocks/categories/editor-rtl.css 84 B
build/block-library/blocks/categories/editor.css 83 B
build/block-library/blocks/categories/style-rtl.css 79 B
build/block-library/blocks/categories/style.css 79 B
build/block-library/blocks/code/style-rtl.css 90 B
build/block-library/blocks/code/style.css 90 B
build/block-library/blocks/columns/editor-rtl.css 206 B
build/block-library/blocks/columns/editor.css 205 B
build/block-library/blocks/columns/style-rtl.css 503 B
build/block-library/blocks/columns/style.css 502 B
build/block-library/blocks/cover/editor-rtl.css 546 B
build/block-library/blocks/cover/editor.css 547 B
build/block-library/blocks/embed/editor-rtl.css 488 B
build/block-library/blocks/embed/editor.css 488 B
build/block-library/blocks/embed/style-rtl.css 417 B
build/block-library/blocks/embed/style.css 417 B
build/block-library/blocks/embed/theme-rtl.css 124 B
build/block-library/blocks/embed/theme.css 124 B
build/block-library/blocks/file/editor-rtl.css 300 B
build/block-library/blocks/file/editor.css 300 B
build/block-library/blocks/file/style-rtl.css 255 B
build/block-library/blocks/file/style.css 255 B
build/block-library/blocks/file/view.min.js 322 B
build/block-library/blocks/freeform/editor-rtl.css 2.44 kB
build/block-library/blocks/freeform/editor.css 2.44 kB
build/block-library/blocks/gallery/editor-rtl.css 977 B
build/block-library/blocks/gallery/editor.css 982 B
build/block-library/blocks/gallery/theme-rtl.css 122 B
build/block-library/blocks/gallery/theme.css 122 B
build/block-library/blocks/group/editor-rtl.css 159 B
build/block-library/blocks/group/editor.css 159 B
build/block-library/blocks/group/style-rtl.css 57 B
build/block-library/blocks/group/style.css 57 B
build/block-library/blocks/group/theme-rtl.css 78 B
build/block-library/blocks/group/theme.css 78 B
build/block-library/blocks/heading/style-rtl.css 114 B
build/block-library/blocks/heading/style.css 114 B
build/block-library/blocks/home-link/style-rtl.css 247 B
build/block-library/blocks/home-link/style.css 247 B
build/block-library/blocks/html/editor-rtl.css 332 B
build/block-library/blocks/html/editor.css 333 B
build/block-library/blocks/image/editor-rtl.css 731 B
build/block-library/blocks/image/editor.css 730 B
build/block-library/blocks/image/style-rtl.css 507 B
build/block-library/blocks/image/style.css 511 B
build/block-library/blocks/image/theme-rtl.css 124 B
build/block-library/blocks/image/theme.css 124 B
build/block-library/blocks/latest-comments/style-rtl.css 284 B
build/block-library/blocks/latest-comments/style.css 284 B
build/block-library/blocks/latest-posts/editor-rtl.css 137 B
build/block-library/blocks/latest-posts/editor.css 137 B
build/block-library/blocks/latest-posts/style-rtl.css 528 B
build/block-library/blocks/latest-posts/style.css 527 B
build/block-library/blocks/list/style-rtl.css 94 B
build/block-library/blocks/list/style.css 94 B
build/block-library/blocks/media-text/editor-rtl.css 266 B
build/block-library/blocks/media-text/editor.css 263 B
build/block-library/blocks/media-text/style-rtl.css 493 B
build/block-library/blocks/media-text/style.css 490 B
build/block-library/blocks/more/editor-rtl.css 431 B
build/block-library/blocks/more/editor.css 431 B
build/block-library/blocks/navigation-link/editor-rtl.css 649 B
build/block-library/blocks/navigation-link/editor.css 650 B
build/block-library/blocks/navigation-link/style-rtl.css 94 B
build/block-library/blocks/navigation-link/style.css 94 B
build/block-library/blocks/navigation-submenu/editor-rtl.css 299 B
build/block-library/blocks/navigation-submenu/editor.css 299 B
build/block-library/blocks/navigation-submenu/style-rtl.css 213 B
build/block-library/blocks/navigation-submenu/style.css 213 B
build/block-library/blocks/navigation-submenu/view.min.js 343 B
build/block-library/blocks/navigation/view.min.js 2.74 kB
build/block-library/blocks/nextpage/editor-rtl.css 395 B
build/block-library/blocks/nextpage/editor.css 395 B
build/block-library/blocks/page-list/editor-rtl.css 377 B
build/block-library/blocks/page-list/editor.css 377 B
build/block-library/blocks/page-list/style-rtl.css 172 B
build/block-library/blocks/page-list/style.css 172 B
build/block-library/blocks/paragraph/editor-rtl.css 157 B
build/block-library/blocks/paragraph/editor.css 157 B
build/block-library/blocks/paragraph/style-rtl.css 273 B
build/block-library/blocks/paragraph/style.css 273 B
build/block-library/blocks/post-author/style-rtl.css 175 B
build/block-library/blocks/post-author/style.css 176 B
build/block-library/blocks/post-comments/style-rtl.css 492 B
build/block-library/blocks/post-comments/style.css 493 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B
build/block-library/blocks/post-excerpt/editor.css 73 B
build/block-library/blocks/post-excerpt/style-rtl.css 69 B
build/block-library/blocks/post-excerpt/style.css 69 B
build/block-library/blocks/post-featured-image/editor-rtl.css 396 B
build/block-library/blocks/post-featured-image/editor.css 397 B
build/block-library/blocks/post-featured-image/style-rtl.css 156 B
build/block-library/blocks/post-featured-image/style.css 156 B
build/block-library/blocks/post-template/editor-rtl.css 99 B
build/block-library/blocks/post-template/editor.css 98 B
build/block-library/blocks/post-template/style-rtl.css 391 B
build/block-library/blocks/post-template/style.css 392 B
build/block-library/blocks/post-terms/style-rtl.css 73 B
build/block-library/blocks/post-terms/style.css 73 B
build/block-library/blocks/preformatted/style-rtl.css 103 B
build/block-library/blocks/preformatted/style.css 103 B
build/block-library/blocks/pullquote/editor-rtl.css 198 B
build/block-library/blocks/pullquote/editor.css 198 B
build/block-library/blocks/pullquote/style-rtl.css 378 B
build/block-library/blocks/pullquote/style.css 378 B
build/block-library/blocks/pullquote/theme-rtl.css 167 B
build/block-library/blocks/pullquote/theme.css 167 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B
build/block-library/blocks/query-pagination/editor-rtl.css 262 B
build/block-library/blocks/query-pagination/editor.css 255 B
build/block-library/blocks/query-pagination/style-rtl.css 234 B
build/block-library/blocks/query-pagination/style.css 231 B
build/block-library/blocks/query/editor-rtl.css 131 B
build/block-library/blocks/query/editor.css 132 B
build/block-library/blocks/quote/style-rtl.css 187 B
build/block-library/blocks/quote/style.css 187 B
build/block-library/blocks/quote/theme-rtl.css 223 B
build/block-library/blocks/quote/theme.css 226 B
build/block-library/blocks/rss/editor-rtl.css 202 B
build/block-library/blocks/rss/editor.css 204 B
build/block-library/blocks/rss/style-rtl.css 289 B
build/block-library/blocks/rss/style.css 288 B
build/block-library/blocks/search/editor-rtl.css 165 B
build/block-library/blocks/search/editor.css 165 B
build/block-library/blocks/search/style-rtl.css 397 B
build/block-library/blocks/search/style.css 398 B
build/block-library/blocks/search/theme-rtl.css 64 B
build/block-library/blocks/search/theme.css 64 B
build/block-library/blocks/separator/editor-rtl.css 99 B
build/block-library/blocks/separator/editor.css 99 B
build/block-library/blocks/separator/style-rtl.css 245 B
build/block-library/blocks/separator/style.css 245 B
build/block-library/blocks/separator/theme-rtl.css 172 B
build/block-library/blocks/separator/theme.css 172 B
build/block-library/blocks/shortcode/editor-rtl.css 474 B
build/block-library/blocks/shortcode/editor.css 474 B
build/block-library/blocks/site-logo/editor-rtl.css 770 B
build/block-library/blocks/site-logo/editor.css 770 B
build/block-library/blocks/site-logo/style-rtl.css 165 B
build/block-library/blocks/site-logo/style.css 165 B
build/block-library/blocks/site-tagline/editor-rtl.css 86 B
build/block-library/blocks/site-tagline/editor.css 86 B
build/block-library/blocks/site-title/editor-rtl.css 84 B
build/block-library/blocks/site-title/editor.css 84 B
build/block-library/blocks/social-link/editor-rtl.css 177 B
build/block-library/blocks/social-link/editor.css 177 B
build/block-library/blocks/social-links/editor-rtl.css 824 B
build/block-library/blocks/social-links/editor.css 823 B
build/block-library/blocks/social-links/style-rtl.css 1.32 kB
build/block-library/blocks/social-links/style.css 1.32 kB
build/block-library/blocks/spacer/editor-rtl.css 307 B
build/block-library/blocks/spacer/editor.css 307 B
build/block-library/blocks/spacer/style-rtl.css 48 B
build/block-library/blocks/spacer/style.css 48 B
build/block-library/blocks/table/editor-rtl.css 471 B
build/block-library/blocks/table/editor.css 472 B
build/block-library/blocks/table/style-rtl.css 481 B
build/block-library/blocks/table/style.css 481 B
build/block-library/blocks/table/theme-rtl.css 188 B
build/block-library/blocks/table/theme.css 188 B
build/block-library/blocks/tag-cloud/style-rtl.css 146 B
build/block-library/blocks/tag-cloud/style.css 146 B
build/block-library/blocks/template-part/editor-rtl.css 560 B
build/block-library/blocks/template-part/editor.css 559 B
build/block-library/blocks/template-part/theme-rtl.css 101 B
build/block-library/blocks/template-part/theme.css 101 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B
build/block-library/blocks/text-columns/editor.css 95 B
build/block-library/blocks/text-columns/style-rtl.css 166 B
build/block-library/blocks/text-columns/style.css 166 B
build/block-library/blocks/verse/style-rtl.css 87 B
build/block-library/blocks/verse/style.css 87 B
build/block-library/blocks/video/style-rtl.css 173 B
build/block-library/blocks/video/style.css 173 B
build/block-library/blocks/video/theme-rtl.css 124 B
build/block-library/blocks/video/theme.css 124 B
build/block-library/common-rtl.css 815 B
build/block-library/common.css 812 B
build/block-library/reset-rtl.css 474 B
build/block-library/reset.css 474 B
build/block-serialization-default-parser/index.min.js 1.09 kB
build/block-serialization-spec-parser/index.min.js 2.79 kB
build/customize-widgets/style-rtl.css 1.5 kB
build/customize-widgets/style.css 1.49 kB
build/dom-ready/index.min.js 304 B
build/edit-navigation/style-rtl.css 3.76 kB
build/edit-navigation/style.css 3.76 kB
build/edit-post/classic-rtl.css 492 B
build/edit-post/classic.css 494 B
build/edit-widgets/style.css 4.18 kB
build/editor/style-rtl.css 3.78 kB
build/editor/style.css 3.77 kB
build/escape-html/index.min.js 517 B
build/format-library/style-rtl.css 571 B
build/format-library/style.css 571 B
build/html-entities/index.min.js 424 B
build/is-shallow-equal/index.min.js 501 B
build/list-reusable-blocks/style-rtl.css 838 B
build/list-reusable-blocks/style.css 838 B
build/nux/style-rtl.css 747 B
build/nux/style.css 743 B
build/priority-queue/index.min.js 582 B
build/react-i18n/index.min.js 671 B
build/reusable-blocks/style-rtl.css 256 B
build/reusable-blocks/style.css 256 B
build/warning/index.min.js 248 B
build/widgets/style-rtl.css 1.16 kB
build/widgets/style.css 1.16 kB
build/wordcount/index.min.js 1.04 kB

compressed-size-action

@ramonjd ramonjd self-assigned this Nov 10, 2021
@ramonjd ramonjd marked this pull request as ready for review November 10, 2021 22:53
@ramonjd ramonjd changed the title Letter spacing: update label margin and copy Letter spacing: update label copy Nov 11, 2021
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copy change LGTM 👍

I left one small comment regarding an unneeded class name. Once that is removed this should be good to go.

Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the classname removal, this is ready to ship :shipit:

✅ Copy looks good
✅ Reordered stylesheets are still imported correctly

@ramonjd ramonjd merged commit 09ee3ab into trunk Nov 16, 2021
@ramonjd ramonjd deleted the update/letter-spacing-label branch November 16, 2021 00:54
@github-actions github-actions bot added this to the Gutenberg 12.0 milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants