Search: Add contextual defaults when inserted in Navigation block #36125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Package] Block library
ntsekouras
requested review from
Mamaduka,
youknowriad,
vcanales,
jasmussen and
tellthemachines
ntsekouras
commented
Nov 1, 2021
| @@ -288,7 +288,9 @@ function navStripHTML( html ) { | |||
| function LinkControlTransforms( { block, transforms, replace } ) { | |||
| return ( | |||
| <div className="link-control-transform"> | |||
| <h3 className="link-control-transform__subheading">Transform</h3> | |||
| <h3 className="link-control-transform__subheading"> | |||
| { __( 'Transform' ) } | |||
There was a problem hiding this comment.
Unrelated, but needed 😄
7 tasks
|
Size Change: +154 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Thanks, Nik.
This enhancement works as expected and doesn't suffers from the issue of updating existing blocks.
I also like @talldan's suggestion about using variations for contextual defaults, but I think we can explore this when more blocks need this feature.
|
We can also close the original PR once this gets merged - #35688. |
|
Beautiful work, the search block is inserted with good defaults and feels much more useful inside the navigation container: Ship it! |
|
Thank you Nik, George and Vicente for all tackling this challenge! |
andrewserong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #31127
This PR is an alternative of #36026 and adds some defaults to the
Searchblock, when inserted inNavigationblock.Testing instructions
Searchblock in a Navigation block and observe that gets the desired defaultsSearchand observe that still gets the desired defaultsSearchoutside ofNavigationand observe that has the base defaultsNotes
I used
wasBlockJustInsertedselector, but in general I think this selector needs more study to make it work more reliably. I believe this works fine (as per my testing) forNavigationblock, just because we can't have theslash inserterinside this block.I tried adding the
Groupas another parent to check to apply these defaults but this works only when themain and quickinserters are used.wasBlockJustInsertedupdates its value inINSERT_BLOCKSaction, but theslash inserter(block autocompleter) dispatches anREPLACE_BLOCKSaction when a block is added.