Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Block: Enable contextual defaults #31127

Closed
jasmussen opened this issue Apr 23, 2021 · 0 comments · Fixed by #36125
Closed

Search Block: Enable contextual defaults #31127

jasmussen opened this issue Apr 23, 2021 · 0 comments · Fixed by #36125
Assignees
@ntsekouras
Labels
[Block] Search Affects the Search Block - used to display a search field [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

What problem does this address?

When you insert a Search block, it comes with good basic defaults:

Screenshot 2021-04-23 at 13 14 41

But when the Search block is inserted in, for example, a horizontal Navigation block, those defaults are less useful:

Screenshot 2021-04-23 at 13 15 43

What is your proposed solution?

It would be nice if the Search block could have a contextual default to say that the external label was only visible if it was inserted as a standalone block. So when inserted in a container, such as Navigation, it would default to not having the label above:

Screenshot 2021-04-23 at 13 16 53
@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. [Block] Search Affects the Search Block - used to display a search field labels Apr 23, 2021
@jasmussen jasmussen mentioned this issue Apr 23, 2021
Closed
12 tasks
@vcanales vcanales mentioned this issue Oct 15, 2021
Closed
@jasmussen jasmussen mentioned this issue Oct 18, 2021
Closed
16 tasks
@Mamaduka Mamaduka mentioned this issue Oct 28, 2021
Closed
7 tasks
@ntsekouras ntsekouras mentioned this issue Nov 1, 2021
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 1, 2021
@jasmussen jasmussen mentioned this issue Mar 16, 2023
Closed
32 tasks
@t-hamano t-hamano mentioned this issue Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntsekouras ntsekouras

Labels
[Block] Search Affects the Search Block - used to display a search field [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Search: Add contextual defaults when inserted in Navigation block WordPress/gutenberg
2 participants
@jasmussen @ntsekouras