Inserter: Fix handling of child blocks #23231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
3 tasks
|
Size Change: -54 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jun 17, 2020
| <ChildBlocks | ||
| rootClientId={ rootClientId } | ||
| // Pass along every block, as getInserterItems() will have | ||
| // already filtered out non-child blocks. |
There was a problem hiding this comment.
This comment makes me wonder what's special about ChildBlocks component. Why not just render BlockTypesList directly?
There was a problem hiding this comment.
They receive different visual treatments.
Here's ChildBlocks:
Here's InserterPanel:
Perhaps we should unify the two? I'd rather address this as a separate issue, though.
In the meantime I agree that ChildBlocks should at least work the same as InserterPanel where the parent is responsible for passing through BlockTypes. I've changed that in 866b98e2f4.
There was a problem hiding this comment.
Yes, seems like unnecessary complexity for now. I believe the visual difference is from the old design.
noisysocks
requested review from
ajitbohra,
ellatrix,
nerrad,
ntwb and
talldan
as code owners
talldan
approved these changes
Jun 18, 2020
It was probably introduced in #20880, but I haven't confirmed that. I'd not be surprised if no third parties are using this functionality since it's not very well documented and we don't (yet) use it ourselves! |
When a block C specifies `parent: [ P ]`, it means that C may only be
added to P. It does NOT mean that P may *only* contain C. (Which is what
`<InnerBlocks allowedBlocks={ [ C ] }>` means.)
This fixes the Inserter so that the correct blocks are shown when
inserting into a block that is referenced by `parent`. It does so by
leaning on `getInserterItems()` which does the right thing.
noisysocks
force-pushed
the
fix/child-blocks
branch
from
0cad806
to
8b5ca5a
Compare
This was referenced Jun 24, 2020
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23227. Necessary for #22656.
When a block C specifies
parent: [ P ], it means that C may only be added to P. It does NOT mean that P may only contain C. (Which is what<InnerBlocks allowedBlocks={ [ C ] }>means.)This fixes the Inserter so that the correct blocks are shown when inserting into a block that is referenced by
parent. It does so by leaning ongetInserterItems()which already does the right thing.To test
Paste the following snippet into the DevTools console:
Snippet
The Paragraph, Image and Add to Cart blocks should appear in the Inserter.