Refactor the inserter menu component and split into multiple smaller components #20880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Inserter
|
Size Change: -82 B (0%) Total Size: 857 kB
ℹ️ View Unchanged
|
|
Inserter seems to work well for me overall. One change, though, I see all categories expanded, except "Most Recent". Honestly I think the categories are a failed experiment, so that aspect does not bother me — though if this is an intentional change I'd also make the Most Recent be expanded by default. |
gziolo
reviewed
Mar 16, 2020
| import { useInstanceId } from '@wordpress/compose'; | ||
| import { __ } from '@wordpress/i18n'; | ||
|
|
||
| function InserterSearchForm( { onChange } ) { |
There was a problem hiding this comment.
Technically speaking, it's not a form :)
I'm wondering if it should be converted to form separately.
I restored the previous behavior. Let's consider changes here separately (we can maybe remove the collapsing at some point) |
|
Cool, fine with exploring that separately. That was the only behavior change I noted, so per your testing instructions I will defer to Gzregorz on the thumbs up! |
gziolo
reviewed
Mar 16, 2020
|
There are still some failing unit tests ( |
|
I've been battling with these tests for hours now :). I'm on the right track though :P |
|
yay tests fixed. |
gziolo
approved these changes
Mar 17, 2020
youknowriad
force-pushed
the
refactor/inserter
branch
from
8d3d2a1
to
c38ec3e
Compare
|
I believe this PR introduced a recent bug I filed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare the addition of the block patterns into the Main Block Inserter, this PR refactors the code base of the InserterMenu component and split it into separate smaller components.
It rewrites some of it with React hooks at the same time.
Testing instructions