Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover: Add Padding Styles #21492

Merged
merged 106 commits into from
Jun 3, 2020
Merged

Cover: Add Padding Styles #21492

merged 106 commits into from
Jun 3, 2020

Commits on May 13, 2020

  1. Creating initial BoxControl component

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    66ec200 View commit details
    Browse the repository at this point in the history

  2. Add BoxControlIcon

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    dff4163 View commit details
    Browse the repository at this point in the history

  3. Add Flex component and integrate into BoxControl component

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    7904c75 View commit details
    Browse the repository at this point in the history

  4. Add labels for UnitControls

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    0f3c00d View commit details
    Browse the repository at this point in the history

  5. Add react-use-gesture

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    fb77888 View commit details
    Browse the repository at this point in the history

  6. Add drag support to NumberControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    69e4a1c View commit details
    Browse the repository at this point in the history

  7. Improve layout for BoxControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    b0877d1 View commit details
    Browse the repository at this point in the history

  8. Update snapshot tests

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    4f05a24 View commit details
    Browse the repository at this point in the history

  9. Add shiftStep in drag feature in NumberControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    65736fc View commit details
    Browse the repository at this point in the history

  10. Adjust Box control UI

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    779ae5b View commit details
    Browse the repository at this point in the history

  11. Initial integration with Cover

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    d37a6f5 View commit details
    Browse the repository at this point in the history

  12. Integrate PaddingControl with Cover using hooks

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    8ef3f80 View commit details
    Browse the repository at this point in the history

  13. Improve visualization of padding

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    74e327c View commit details
    Browse the repository at this point in the history

  14. Experiment with new Box Controls layout

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    aa790ea View commit details
    Browse the repository at this point in the history

  15. Improve NumberControl drag interaction

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    aa5b18b View commit details
    Browse the repository at this point in the history

  16. Create InputControl primitive. Add floating labels. Refactor BoxControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    7687799 View commit details
    Browse the repository at this point in the history

  17. Adjust UI for BoxControl + InputControl labels

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    21efbac View commit details
    Browse the repository at this point in the history

  18. Fix tests

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    cd8c007 View commit details
    Browse the repository at this point in the history

  19. Increase CSS scope. Minor label UI adjustments.

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    0acb9ee View commit details
    Browse the repository at this point in the history

  20. Refine UI for BoxControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    ebbf031 View commit details
    Browse the repository at this point in the history

  21. Hook up inline style rendering with padding attribute values

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    85979dd View commit details
    Browse the repository at this point in the history

  22. Adjust tab order for BoxControl inputs to match visual order

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    2f14a64 View commit details
    Browse the repository at this point in the history

  23. Remove padding attribute declaration

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    1352863 View commit details
    Browse the repository at this point in the history

  24. Improve dragging experience

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    9956662 View commit details
    Browse the repository at this point in the history

  25. Add alt pair change support. Improve null value rendering.

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    508124b View commit details
    Browse the repository at this point in the history

  26. Remove unused BoxControl Icon

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    6c8e05d View commit details
    Browse the repository at this point in the history

  27. Improve RTL interactions

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    6dd9a2d View commit details
    Browse the repository at this point in the history

  28. Fix onChange type for NumberControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    58a3968 View commit details
    Browse the repository at this point in the history

  29. Fix NumberControl onChange type

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    33dadc6 View commit details
    Browse the repository at this point in the history

  30. Add Prefix to InputControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    2780a8f View commit details
    Browse the repository at this point in the history

  31. Refine labels for BoxControl inputs

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    789cfd9 View commit details
    Browse the repository at this point in the history

  32. Adjust BoxControl Y indicator hieght

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    23e252d View commit details
    Browse the repository at this point in the history

  33. Refactor BoxControl inputs + update tests

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    0a490f0 View commit details
    Browse the repository at this point in the history

  34. Fix left tooltip label for BoxControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    3e48e86 View commit details
    Browse the repository at this point in the history

  35. Refactor number-control styles

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    b9ecc2b View commit details
    Browse the repository at this point in the history

  36. Adding isPressToSubmit to unit-control

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    bd522f6 View commit details
    Browse the repository at this point in the history

  37. Improve press enter to change mechanic for NumberControl. 

    Refactors Input/Number/Unit control components to add classNames and streamline logic flow.
    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    73f8215 View commit details
    Browse the repository at this point in the history

  38. Introduce unit parsing

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    3b2b4dc View commit details
    Browse the repository at this point in the history

  39. Stabilized value/unit parsing

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    51d42d9 View commit details
    Browse the repository at this point in the history

  40. Add unit support to Cover block padding. 

    Also refine interactions
    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    27fd539 View commit details
    Browse the repository at this point in the history

  41. Hook up custom units via add_theme_support with Padding controls

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    31ef976 View commit details
    Browse the repository at this point in the history

  42. Use floating labels for BoxControl inputs. 

    Also add disabled styles to InputControl
    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    b447ee6 View commit details
    Browse the repository at this point in the history

  43. Remove tooltip from InputControl. Refactor + update docs.

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    aba8973 View commit details
    Browse the repository at this point in the history

  44. Add InputControl docs to docs/manifest.json

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    7cecdaf View commit details
    Browse the repository at this point in the history

  45. Fix tests for UnitControl. Adds tests for value/unit parsing.

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    8fb4dea View commit details
    Browse the repository at this point in the history

  46. Update docs for InputControl and NumberControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    8b282df View commit details
    Browse the repository at this point in the history

  47. Update docs and code comments for Input, Number, and Unit control

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    e6e4548 View commit details
    Browse the repository at this point in the history

  48. Fix BoxControl rendering

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    2ebfcba View commit details
    Browse the repository at this point in the history

  49. Fix block editor hook for padding styles

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    da3cb72 View commit details
    Browse the repository at this point in the history

  50. Cover: Fix BoxControl visualizer rendering

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    be8dedc View commit details
    Browse the repository at this point in the history

  51. Fix classNames for Input, Number, and Unit controls. Improve value/un… 

    …it consolidation
    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    2a497b9 View commit details
    Browse the repository at this point in the history

  52. Improve blur onChange when isPressEnterToChange is set

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    6713a08 View commit details
    Browse the repository at this point in the history

  53. Refactor press enter to change interaction between InputControl and N… 

    …umberControl
    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    1856cc1 View commit details
    Browse the repository at this point in the history

  54. Add Linked adjustment for BoxControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    5c4e7b2 View commit details
    Browse the repository at this point in the history

  55. Refactor and improve render performance of InputControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    16de5ae View commit details
    Browse the repository at this point in the history

  56. Remove defaultUnits static prop

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    23cbeaf View commit details
    Browse the repository at this point in the history

  57. Improves performance and refactors BoxControlVisual styles

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    03ea817 View commit details
    Browse the repository at this point in the history

  58. Resets input value on blur

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    48b489d View commit details
    Browse the repository at this point in the history

  59. Fix coupled side update rendering when holding ALT key

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    623de49 View commit details
    Browse the repository at this point in the history

  60. Adds README for BoxControl and Flex

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    853932f View commit details
    Browse the repository at this point in the history

  61. Update docs manifest

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    8686b4a View commit details
    Browse the repository at this point in the history

  62. Update stories for NumberControl and UnitControl. 

    Also continue cleaning up controls
    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    ed203c7 View commit details
    Browse the repository at this point in the history

  63. Improve unit parsing to handle white space

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    15307d5 View commit details
    Browse the repository at this point in the history

  64. Adjust all vs individual side controls layout

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    db86e9c View commit details
    Browse the repository at this point in the history

  65. Improve value parsing + validation on submit

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    2556e4d View commit details
    Browse the repository at this point in the history

  66. TEMPORARY: Testing inline layout for controls

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    09ddc40 View commit details
    Browse the repository at this point in the history

  67. Implement stateReducer for InputControl, NumberControl, and UnitControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    58956c2 View commit details
    Browse the repository at this point in the history

  68. Fixes tests and wraps up stateReducer update

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    73332d7 View commit details
    Browse the repository at this point in the history

  69. Persist events from Input Control reducer. Add comments. 

    Add number-control value parsing tests on ENTER keypress.
    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    b5e923b View commit details
    Browse the repository at this point in the history

  70. Remove unused useControlledState hook

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    728b5fd View commit details
    Browse the repository at this point in the history

  71. Add default values to InputField props

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    c5586e9 View commit details
    Browse the repository at this point in the history

  72. Improve inline UI for unit controls within BoxControl 

    Also add reset feature to BoxControl
    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    67d5690 View commit details
    Browse the repository at this point in the history

  73. Add opt-in flag for Spacing controls. Improves control integration wi… 

    …th Editor.
    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    34e6cd4 View commit details
    Browse the repository at this point in the history

  74. Rename stateReducer to unstable_stateReducer 

    This helps indicates that the stateReducer prop + pattern, although working,
should probably be avoided for public use outside of @wordpress/component
components (for now).
    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    a93def3 View commit details
    Browse the repository at this point in the history

  75. Remove unnecessary eslint-disable rule

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    2d3fe72 View commit details
    Browse the repository at this point in the history

  76. TEMP: Disable opt-in flag for spacing control for testing purposes.

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    3bc1dce View commit details
    Browse the repository at this point in the history

  77. Streamline combine stateReducer flow. Improve performance with memozi… 

    …ation.
    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    0a972d6 View commit details
    Browse the repository at this point in the history

  78. Improve dragEnd event triggering in InputControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    ce8de26 View commit details
    Browse the repository at this point in the history

  79. Fix memoization issue for state reducer updates

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    7342f4f View commit details
    Browse the repository at this point in the history

  80. Rename unstable_stateReducer to __unstableStateReducer

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    022bd12 View commit details
    Browse the repository at this point in the history

  81. Replace Array.flat with lodash.flattenDeep for IE compatibility

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    e646191 View commit details
    Browse the repository at this point in the history

  82. Fix reset value mechanic stability for BoxControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    78379ae View commit details
    Browse the repository at this point in the history

  83. Add value tests for InputControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    96c5de8 View commit details
    Browse the repository at this point in the history

  84. TEMP: Disable guard for testing

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    e966e62 View commit details
    Browse the repository at this point in the history

  85. Remove fixed height for BoxControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    c40b731 View commit details
    Browse the repository at this point in the history

  86. Make use of combineStateReducers more explicit for InputControl, Numb… 

    …erControl, and UnitControl
    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    0831bf1 View commit details
    Browse the repository at this point in the history

  87. Refactor useBoxControlState to simply useControlledState with defaults

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    4c4a24b View commit details
    Browse the repository at this point in the history

  88. Simplify side active matching for BoxControl/Icon

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    02b51a5 View commit details
    Browse the repository at this point in the history

  89. Update packages/block-editor/src/components/spacing-panel-control/ind… 

    …ex.js

Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
    @mcsf
    Jon Quach and mcsf committed May 13, 2020
    Configuration menu
    Copy the full SHA
    ae40997 View commit details
    Browse the repository at this point in the history

  90. Fix update value on blur

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    0716d21 View commit details
    Browse the repository at this point in the history

  91. Fix tests for UnitControl

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    dab5b21 View commit details
    Browse the repository at this point in the history

  92. Memoize input state reducer to prevent unnecessary re-renders 

    ...which were spotted during unit tests.
    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    609b9c3 View commit details
    Browse the repository at this point in the history

  93. Rename submit -> commit. Fix RTL (from rebase mixup).

    Jon Q committed May 13, 2020
    Configuration menu
    Copy the full SHA
    2818628 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. Update InputControl, NumberControl, and UnitControl from master

    Jon Q committed May 21, 2020
    Configuration menu
    Copy the full SHA
    6a376c0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into try/cover-padding-control

    Jon Q committed May 21, 2020
    Configuration menu
    Copy the full SHA
    2242ccd View commit details
    Browse the repository at this point in the history

  3. Integrate lightBlockWrapper with new padding controls + visualizer

    Jon Q committed May 21, 2020
    Configuration menu
    Copy the full SHA
    c4ada30 View commit details
    Browse the repository at this point in the history

  4. Move __experimentalPadding config to block.json

    Jon Q committed May 21, 2020
    Configuration menu
    Copy the full SHA
    550b742 View commit details
    Browse the repository at this point in the history

  5. Removing leftover comments

    Jon Quach authored May 21, 2020
    Configuration menu
    Copy the full SHA
    b87de71 View commit details
    Browse the repository at this point in the history

  6. Adjust spacing for import comments

    Jon Quach authored May 21, 2020
    Configuration menu
    Copy the full SHA
    46f48ac View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Merge branch 'master' into try/cover-padding-control

    Jon Q committed May 28, 2020
    Configuration menu
    Copy the full SHA
    7ec2ea2 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. Fix padding theme setting check

    Jon Q committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    1cf533a View commit details
    Browse the repository at this point in the history

  2. Add sibling usage for BoxControl.Visualizer in README.md

    Jon Q committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    0d5f647 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. Merge branch 'master' into try/cover-padding-control

    Jon Q committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    e0ff560 View commit details
    Browse the repository at this point in the history

  2. Add more content + image examples to Flex README.md

    Jon Q committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    f263906 View commit details
    Browse the repository at this point in the history

  3. Remove experimental prefix for Flex

    Jon Q committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    f3d22fa View commit details
    Browse the repository at this point in the history

  4. Refactor Flex sub-components to be used/exported without static attac… 

    …hment

Also lint/format files
    Jon Q committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    dbc99ce View commit details
    Browse the repository at this point in the history