Cherry Pick PR's for WordPress 5.4 beta 2 #20275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…columns (#20169) * Block Library: Columns: Fix equal column growth for unassigned-width columns * Block Library: Columns: Restore mid-range viewport styles * Block Library: Columns: Keep margin resets in mid-range viewports Reference from prior to #19515 : https://github.com/WordPress/gutenberg/blob/7997bf66490bab0f6984a114c22ad125f04b9e89/packages/block-library/src/columns/editor.scss#L69-L75 * Block Library: Columns: Update comment to reference mid-range 2 columns
* Format library: link: remove aria-label * Adjust new e2e snap
This hasn't been published to npm yet. We're interested in using it to explore Full Site Editing outside of a 'regular' Gutenberg context, so we'd like to publish it. Note that even though the package hasn't been published yet, the version number has been regularly bumped by the publish script, and it's now at 1.2.0. I'd like to set it to an alpha version (to make clear that it's still in its early stages and not yet ready for production). I've thus chosen 1.3.0-alpha.0 -- I hope that choice is okay.
* adds edit state to frames to fix new tab issue * moves default state build into else of gallery condition and adds gallery toolbar logic to reach parity with Core. * fixes selection object reference to proper state * improves and adds documentation * removes buildAndSetEditFrame as it should be added in core and not here. Also removes the declaration of the button text as the default already is 'select' * truly removes editState fu function * fixes linting issues * Adjusts PR to factor in review suggestions
jorgefilipecosta
requested review from
ajitbohra,
chrisvanpatten,
daniloercoli,
ellatrix,
etoledom,
nerrad,
ntwb,
SergioEstevao,
Soean,
talldan and
youknowriad
as code owners
jorgefilipecosta
added
the
[Type] Project Management
jorgefilipecosta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR cherry picks the following PR's into wp/trunk:
This PR will be part of WordPress 5.4 beta 2.
How has this been tested?
I did some smoke tests and verified the branch, in fact, contained the expected fixes.