Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make label Open in new tab consistent. #20209

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Conversation

Soean
Copy link
Member

@Soean Soean commented Feb 13, 2020

Description

At the moment we use Open in new tab and Open in New Tab as label. To make it more consistent and easy for translation, we should change all labels to Open in new tab.

@Soean Soean added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Feb 13, 2020
@aduth
Copy link
Member

aduth commented Feb 13, 2020

To make it more consistent and easy for translation, we should change all labels to Open in new tab.

Are the standards around this documented anywhere?

Related: #20187 (comment)

Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jorgefilipecosta jorgefilipecosta merged commit 73eaacb into master Feb 17, 2020
@jorgefilipecosta jorgefilipecosta deleted the update/open-in-new-tab branch February 17, 2020 19:04
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 17, 2020
@jorgefilipecosta jorgefilipecosta added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 17, 2020
@jorgefilipecosta jorgefilipecosta removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants