Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch all terms linked to a post, rather than just first 100 #11524

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Nov 6, 2018

Description

Fetches all terms linked to a post, rather than just the first 100 per taxonomy.
This relies upon the fetch-all middleware.

This is part of #10873

How has this been tested?

By adding 240 tags to a post, verifying that they're limited to 100 prior, shows 240 afterwards.

@danielbachhuber danielbachhuber added REST API Interaction Related to REST API [Type] Bug An existing feature does not function as intended labels Nov 6, 2018
@danielbachhuber
Copy link
Member

This relies upon the fetch-all middleware.

Great find! I wish I had thought of that :)

Locally, I get a 502 Bad Gateway with this branch when I have 201 terms assigned to my post:

image

My hunch is that it has to do with the total length of the include query argument. When I switch back to the master branch, I have the same problem.

@danielbachhuber
Copy link
Member

danielbachhuber commented Nov 6, 2018

Another imprecise behavior I noticed: even though the request for terms failed, the Tag Post Setting appears like this:

image

I would've expected the Tag Post Setting to better communicate it's incomplete / failed state. I'll note on #6723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REST API Interaction Related to REST API [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants