Fetch all potential categories, attachments, and tags

[danielbachhuber]

There are a few API fetch instances using per_page=100 that should instead fetch all of their items:

1. getAttachmentsCollection() in packages/edit-post/src/hooks/components/media-upload/index.js: 0a08388

2. The following code in FlatTermSelector: Fetch all terms linked to a post, rather than just first 100 #11524

this.initRequest = this.fetchTerms( {
	include: this.props.terms.join( ',' ),
	per_page: 100,
} );

Even though it's unlikely a user will have 101 tags, Gutenberg will silently discard their 101st tag as fetchTerms() is currently implemented.

3. componentWillMount() in packages/block-library/src/latest-posts/edit.js: Run the E2E tests as a user with the author role #11359 (comment)

From https://github.com/WordPress/gutenberg/pull/10762/files/8803b88e7e7eed8f73aba32b52608175b1a2e858#diff-781b45da3dbed5d2670d2c98e473fb83

[dd32]

#11524 is me testing out the changes needed here.

I've verified that Item 2 in FlatTermSelector was indeed an issue, and patched that.

I've been looking into Item 1, but I've been struggling to actually trigger the problematic code.

[danielbachhuber]

I've been looking into Item 1, but I've been struggling to actually trigger the problematic code.

@dd32 This has some fun origins:

• It looks like getAttachmentsCollection() was changed to use per_page=100 from per_page=-1 in dee3dcf#diff-781b45da3dbed5d2670d2c98e473fb83R67
• But as it turns out, wp_ajax_query_attachments expects posts_per_page=-1, not per_page=-1, so the code never worked in the first place: https://github.com/WordPress/wordpress-develop/blob/17304432063cf2a0635cd93a554a7a08c24a7224/src/wp-admin/includes/ajax-actions.php#L2648
• perPage=-1 was originally added in d13a862#diff-b6cad109f99d0fc5133d2f1408686371R70 (from Gallery: Update media frame state management #2488)

I think what getAttachmentsCollection() is meant to do is prime the attachment data used in the Media Library. I also believe that, if the attachment data is missing, the Media Library will refetch it.

@joemcgill Does this match your understanding?

[danielbachhuber]

The two remaining issues were addressed in #11654 and #11655