Fix: Show resizer on "Media & Text" block on unified toolbar mode #10913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
changed the title
jorgefilipecosta
changed the title
Soean
approved these changes
Oct 22, 2018
jorgefilipecosta
deleted the
fix/media-and-text-resizer-unified-toolbar
branch
youknowriad
pushed a commit
that referenced
this pull request
Oct 24, 2018
…0913) ## Description Fixes: #10895 On unified toolbar mode, it was not possible to resize the media on Media & Text block. During the elaboration of #9416 this bug was addressed but I think during subsequent rebases and changes more concretely the usage of our abstracted Resizable box we had a regression. This PR applies exactly the same fix that was applied in spacer block to the Media & Text block. ## How has this been tested? I checked it is possible to resize the media in Media & Text block in all modes including the unified toolbar.
antpb
pushed a commit
to antpb/gutenberg
that referenced
this pull request
Oct 26, 2018
…rdPress#10913) ## Description Fixes: WordPress#10895 On unified toolbar mode, it was not possible to resize the media on Media & Text block. During the elaboration of WordPress#9416 this bug was addressed but I think during subsequent rebases and changes more concretely the usage of our abstracted Resizable box we had a regression. This PR applies exactly the same fix that was applied in spacer block to the Media & Text block. ## How has this been tested? I checked it is possible to resize the media in Media & Text block in all modes including the unified toolbar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #10895
On unified toolbar mode it was not possible to resize the media on Media & Text block.
During the elaboration of #9416 this bug was addressed but I think during subsequent rebases and changes more concretely the usage of our abstracted Resizable box we had a regression.
This PR applies exactly the same fix that was applied in spacer block to the Media & Text block.
How has this been tested?
I checked it is possible to resize the media in Media & Text block in all mode including the unified toolbar.