Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media & Text: Can't resize image with unified Toolbar #10895

Closed
Soean opened this issue Oct 22, 2018 · 2 comments · Fixed by #10913
Closed

Media & Text: Can't resize image with unified Toolbar #10895

Soean opened this issue Oct 22, 2018 · 2 comments · Fixed by #10913
Labels
[Type] Bug An existing feature does not function as intended

Comments

@Soean
Copy link
Member

Soean commented Oct 22, 2018

Describe the bug
If I activate the unified toolbar, I am not able to resize the image in the new Media & Text block.

@Soean Soean added the [Type] Bug An existing feature does not function as intended label Oct 22, 2018
@Soean Soean added this to the 4.1 - UI freeze milestone Oct 22, 2018
@designsimply
Copy link
Member

designsimply commented Oct 22, 2018

Tested and confirmed with WordPress 4.9.8 and Gutenberg 4.1.0-rc.2 that I cannot see a drag handle to resize an image in the Media & Text block when the Unified Toolbar is active.

screen shot 2018-10-22 at 7 10 39 am

screen shot 2018-10-22 at 7 10 19 am

Seen at http://alittletestblog.com/wp-admin/post.php?post=15235&action=edit running WordPress 4.9.8 and Gutenberg 4.1.0-rc.2 using Firefox 62.0.3 on macOS 10.13.6.

@jorgefilipecosta
Copy link
Member

Thank you for reporting this issue @Soean!

jorgefilipecosta added a commit that referenced this issue Oct 23, 2018
…0913)

## Description
Fixes: #10895
On unified toolbar mode, it was not possible to resize the media on Media & Text block.
During the elaboration of #9416 this bug was addressed but I think during subsequent rebases and changes more concretely the usage of our abstracted Resizable box we had a regression.

This PR applies exactly the same fix that was applied in spacer block to the Media & Text block.


## How has this been tested?
I checked it is possible to resize the media in Media & Text block in all modes including the unified toolbar.
youknowriad pushed a commit that referenced this issue Oct 24, 2018
…0913)

## Description
Fixes: #10895
On unified toolbar mode, it was not possible to resize the media on Media & Text block.
During the elaboration of #9416 this bug was addressed but I think during subsequent rebases and changes more concretely the usage of our abstracted Resizable box we had a regression.

This PR applies exactly the same fix that was applied in spacer block to the Media & Text block.


## How has this been tested?
I checked it is possible to resize the media in Media & Text block in all modes including the unified toolbar.
antpb pushed a commit to antpb/gutenberg that referenced this issue Oct 26, 2018
…rdPress#10913)

## Description
Fixes: WordPress#10895
On unified toolbar mode, it was not possible to resize the media on Media & Text block.
During the elaboration of WordPress#9416 this bug was addressed but I think during subsequent rebases and changes more concretely the usage of our abstracted Resizable box we had a regression.

This PR applies exactly the same fix that was applied in spacer block to the Media & Text block.


## How has this been tested?
I checked it is possible to resize the media in Media & Text block in all modes including the unified toolbar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants