Fix guided tour popup margins #10295
Conversation
There was a problem hiding this comment.
Thanks for the patch!
I think this makes sense and looks good, but I'm a bit confused about the screenshots you've submitted. It looks like there are "before" and "after" screenshots, but I can't tell which ones are which so it's hard to tell what the change is here.
Could you edit your PR comment to clarify the before/after screenshots and have a look at the comments I made? After that this should be good to merge 😄
package-lock.json
Outdated
| @@ -2415,6 +2415,7 @@ | |||
| "version": "file:packages/rich-text", | |||
| "requires": { | |||
| "@babel/runtime": "^7.0.0", | |||
| "@wordpress/escape-html": "file:packages/escape-html", | |||
There was a problem hiding this comment.
Hmmm, this seems unrelated, any idea why this is here?
(If you aren't sure it's probably best to remove. Maybe we forgot to update the package lock, but that can be a separate patch 🙂)
There was a problem hiding this comment.
Not sure how this ended up here, but I'll remove it.
There was a problem hiding this comment.
Just removed it and added commit 25ce95d.
There was a problem hiding this comment.
It wasn't your fault! (See: #10304) 😄
| } | ||
|
|
||
| .components-popover.edit-post-more-menu__content:not(.is-mobile):not(.is-middle).is-right & { | ||
| /*!rtl:ignore*/ |
There was a problem hiding this comment.
Could you add some comments explaining why these should be ignored? Maybe even just a link to this PR, just so future developers will understand.
There was a problem hiding this comment.
*!rtl:ignore*/ came from the CSS statement before, which I copied and adjusted.
|
@tofumatt Thanks for your feedback. I made the screenshots smaller and added title tags to it, thus, when you hover over the images, you'll see their titles and will reply to your other notes directly in the related sections. |
|
@tofumatt Besides the screenshots you've requested, is there anything else I should change in order to get this PR merged? 😉 |
|
Nope, sorry, just didn't see this was ready for another review; looking now! |
|
Great to see this PR got merged, @tofumatt! It's my first contribution to Gutenberg and most likely not the last. 😀 |
Description
Removed negative left and right margins from guided tour popup when scrolling on mobile devices.
How has this been tested?
Fix had been tested using iPhone 7 Plus with iOS 11.4.1 in both English (LTR) and Hebrew (RTL).
Screenshots
Before
After
Types of changes
Removed two negative margins (LTR & RTL) within
gutenberg/packages/components/src/popover/style.scssChecklist: