MongoDB support, concurrent streams, player/backend file handling refactor, and more! #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w concurrent stream component
…mprove maintainability, consistency, and reliability Playlists now use uids instead of fileNames Added generic getPlaylist and updatePlaylist functions
Tzahi12345
added
is: bug
…nloading functionality to new schema Migrated modify playlist component to new schema Moved wait function and playlist generation function(s) to utils - added tests for zip generation
Removed tomp3 and tomp4 routes, replaced with /downloadFile Simplified category->playlist conversion Simplified playlist creation Simplified file deletion Playlist duration calculation is now done on the backend (categories uses this now too) removeIDFromArchive moved from subscriptions->utils Added plumbing to support type agnostic playlists
Added support for MongoDB Added tests relating to new DB system Category rules are now case insensitive Fixed playlist modification change state
… when in dev mode
Closed
This was referenced Jul 19, 2021
Fixed db backup functionality
Massive insertions to local DB are now split up into 30k chunks
…nsole due to vars being changed after Angular detection Fixed spooky issue where recent videos' navigateToFile stopped working
…rial into concurrent-streams-and-player-refactor
Tzahi12345
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prologue
Normally I don't like to combine unrelated additions into one PR but the concurrent streaming functionality (see #171) and refactor of the player component go hand in hand. Once that was done, it seemed natural to update file download (to browser)/deletion process to use file UIDs instead of relying on their name (which we confusingly called ID).
Once I made these changes, I couldn't help myself to refactoring all DB calls to be more platform-agnostic. And thus, MongoDB support was born.
I also added some backend unit tests as a sanity check for DB operations and file access on shared videos -- we didn't have any unit tests and so this is much needed. There's still a lot of backend refactoring to do but this is a huge step forward.
New additions
local_db.jsonfile where you can modify properties and transfer it back. Or, you can just keep it local and it'll work just as it did before.Screenshots:
Database settings
Concurrent streams demo
111569899-4393af00-8769-11eb-9cb6-7b230e2c3a86.mp4