Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please stop using insecure dependencies. #367

Closed
PrivatePuffin opened this issue Apr 17, 2021 · 4 comments · Fixed by #378
Closed

Please stop using insecure dependencies. #367

PrivatePuffin opened this issue Apr 17, 2021 · 4 comments · Fixed by #378
Labels
meta: good first issue Good for newcomers meta: help wanted Help Request for our Codebase/Docs/... SECURITY Things related to the security of the application or its dependencies

Comments

@PrivatePuffin
Copy link

PrivatePuffin commented Apr 17, 2021

Some review of this codebase, leads me to conclude it uses a whole bunch of depricated (and thus) insecure dependencies.

Even automated npm audit --fix solves most of the issues.

@Tzahi12345 Tzahi12345 added meta: good first issue Good for newcomers meta: help wanted Help Request for our Codebase/Docs/... SECURITY Things related to the security of the application or its dependencies labels May 13, 2021
@Tzahi12345
Copy link
Owner

Feel free to put up a PR if you were able to solve most of these issues, I did notice that most of them were related to package-lock.json and so it won't affect the app itself. Will definitely look into this though as it's important.

@PrivatePuffin
Copy link
Author

If you think packages in package-lock.json dont affect the application, I think that says a LOT about the application itself.

I’ve sadly enough no time to submit bugreports for all the apps I make Helmcharts for.

@Tzahi12345
Copy link
Owner

Seems like you're right on this one. I thought it just kept track of the history of package versions, rather than locking the current one.

There's no need to be combative here, I'm not an expert on this stuff and the point of this is to learn together. You are spot on in that this is a relatively serious issue and I'll make sure to address it soon unless someone beats me to it.

@Tzahi12345
Copy link
Owner

Fixed with the latest merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: good first issue Good for newcomers meta: help wanted Help Request for our Codebase/Docs/... SECURITY Things related to the security of the application or its dependencies
Projects
None yet
2 participants