Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASImageNode] Enable .clipsToBounds by default (fix .cornerRadius, GIFs overflow). #466

Merged
merged 3 commits into from
Aug 20, 2017

Commits on Jul 23, 2017

  1. [ASImageNode] Enable .clipsToBounds by default (fix .cornerRadius, GI…

    …Fs overflow).
    
    We've seen a number of bugs reported over time that .cornerRadius didn't work on
    ASNetworkImageNode. This wasn't much of a concern because cornerRadius is very
    inefficient anyway, and there are better ways to round corners, but it should
    certainly work.
    
    It turns out that clipsToBounds has been off for images, and this ultimately
    was behind another issue recently seen wehre decoded GIFs would spill outside
    the bounds area to overlap nearby content.
    
    Although there is some risk of behavior change from this, I think the risk
    is fairly small, and in most cases it will probably fix behaviors in a way
    that doesn't cause problems for the app.
    
    We should consider if this property should be on for all ASDisplayNodes,
    but for now it would be a great step to be confident it's on for all
    ASImageNodes.
    appleguy committed Jul 23, 2017
    Configuration menu
    Copy the full SHA
    1fe9539 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    88f94c8 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2017

  1. Configuration menu
    Copy the full SHA
    9c08466 View commit details
    Browse the repository at this point in the history