[ASImageNode] Enable .clipsToBounds by default (fix .cornerRadius, GIFs overflow). #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fs overflow). We've seen a number of bugs reported over time that .cornerRadius didn't work on ASNetworkImageNode. This wasn't much of a concern because cornerRadius is very inefficient anyway, and there are better ways to round corners, but it should certainly work. It turns out that clipsToBounds has been off for images, and this ultimately was behind another issue recently seen wehre decoded GIFs would spill outside the bounds area to overlap nearby content. Although there is some risk of behavior change from this, I think the risk is fairly small, and in most cases it will probably fix behaviors in a way that doesn't cause problems for the app. We should consider if this property should be on for all ASDisplayNodes, but for now it would be a great step to be confident it's on for all ASImageNodes.
maicki
approved these changes
Jul 23, 2017
There was a problem hiding this comment.
I'm generally fine and as @appleguy said the impact should be reasonable small and the behavior is mostly the one you would like to have. @appleguy just curious is there any performance impact having this property set to YES?
It would differ to the UIKit behavior, if we would enable it for ASDisplayNode though. The interesting thing is that UILabel also overwrites this property and changes it to yes by default. UILabel has this documented, so would be great if we would explicitly document that at least in the header of ASImageNode.
|
Concur with Michael this is a reasonable move, with an assumption that clipsToBounds is pretty fast unless you're masking/rounding corners. But we should document the different default. At first blush I would support generalizing this to ASDisplayNode on that same assumption – having content spill over the bounds should be the exception not the rule. |
|
I believe it is necessary to use ASNetworkImageNode. You can also pass
file:/// URLs to it. Make sure you have PINRemoteImage linked.
…On Mon, Sep 18, 2017 at 6:24 PM wangqian ***@***.***> wrote:
I want to know how to load a GIF Image using ASImageNode,Thanks.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#466 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAigA2EAuQi566xU2psqUdBneglmfhYjks5sjxflgaJpZM4OgYVr>
.
|
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…Fs overflow). (TextureGroup#466) * [ASImageNode] Enable .clipsToBounds by default (fix .cornerRadius, GIFs overflow). We've seen a number of bugs reported over time that .cornerRadius didn't work on ASNetworkImageNode. This wasn't much of a concern because cornerRadius is very inefficient anyway, and there are better ways to round corners, but it should certainly work. It turns out that clipsToBounds has been off for images, and this ultimately was behind another issue recently seen wehre decoded GIFs would spill outside the bounds area to overlap nearby content. Although there is some risk of behavior change from this, I think the risk is fairly small, and in most cases it will probably fix behaviors in a way that doesn't cause problems for the app. We should consider if this property should be on for all ASDisplayNodes, but for now it would be a great step to be confident it's on for all ASImageNodes. * Update changelog for ImageNode Clipping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a number of bugs reported over time that .cornerRadius didn't work on
ASNetworkImageNode. This wasn't much of a concern because cornerRadius is very
inefficient anyway, and there are better ways to round corners, but it should
certainly work.
It turns out that clipsToBounds has been off for images, and this ultimately
was behind another issue recently seen where decoded GIFs would spill outside
the bounds area to overlap nearby content.
Although there is some risk of behavior change from this, I think the risk
is fairly small, and in most cases it will probably fix behaviors in a way
that doesn't cause problems for the app.
We should consider if this property should be on for all ASDisplayNodes,
but for now it would be a great step to be confident it's on for all
ASImageNodes.
One of the reports of this issue:
facebookarchive/AsyncDisplayKit#490