feature(Lists): APPS-6771 Icon changes #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Lists API changed
pbartolome
requested review from
a team,
victorpimentel,
JulianAlonso and
jmpg93
and removed request for
a team
victorpimentel
previously approved these changes
Nov 17, 2020
BREAKING CHANGE: Lists API changed
jmpg93
reviewed
Nov 19, 2020
Comment on lines
27
to
28
| containerView.heightAnchor.constraint(equalToConstant: assetType.viewSize).isActive = true | ||
| containerView.widthAnchor.constraint(equalToConstant: assetType.viewSize).isActive = true |
There was a problem hiding this comment.
These constraints should be declared as lazy, so we can just change the constant value here.
Otherwise, we could potentially keep creating new constraints whenever CellAssetType is changed.
There was a problem hiding this comment.
my mistake!, fixed in 94eebc9
jmpg93
previously approved these changes
Nov 19, 2020
BREAKING CHANGE: Lists API changed
|
@victorpimentel @jmpg93 @JulianAlonso please take a look |
jmpg93
approved these changes
Nov 20, 2020
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lists will now have three different types of icons:
Small icon 24x24:
Large Icon 40x40, a circle with an inner icon of 24x24:
Image 40x40, any image clipped to a circle:
Zeplin