-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(Lists): APPS-6771 Icon changes #31
Conversation
BREAKING CHANGE: Lists API changed
BREAKING CHANGE: Lists API changed
containerView.heightAnchor.constraint(equalToConstant: assetType.viewSize).isActive = true | ||
containerView.widthAnchor.constraint(equalToConstant: assetType.viewSize).isActive = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These constraints should be declared as lazy, so we can just change the constant
value here.
Otherwise, we could potentially keep creating new constraints whenever CellAssetType
is changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my mistake!, fixed in 94eebc9
BREAKING CHANGE: Lists API changed
@victorpimentel @jmpg93 @JulianAlonso please take a look |
🎉 This PR is included in version 6.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Lists will now have three different types of icons:
Small icon 24x24:
Large Icon 40x40, a circle with an inner icon of 24x24:
Image 40x40, any image clipped to a circle:
Zeplin