Remove documentation resources from Mistica artifact #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorpimentel
approved these changes
Nov 30, 2020
pbartolome
approved these changes
Nov 30, 2020
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the task for creating a new workflow which will run the tests of Mistica, I found that we are adding the documentation resources to the final Mistica artifact. This bug only affects to Carthage and Cocoapods because in SPM we are excluding the documentation resources correctly.
In order that this fix appears in the CHANGELOG.md, I think it is better to do the fix in her own branch so we can tag the merge commit en master.
It is just to have a clean history in main branch