Add streamPosition for comments #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How will this work in the UI? |
|
Not sure if it is needed for NewPipe, but we could display a "at 4:20" next to the comment's author name |
|
Oh. So you've added this generally, and not specifically for Newpipe? That is fine. I can't think of a neat way to include this in the app. The UI is too different from how Soundcloud presents it. |
Correct |
Stypox
requested changes
Jun 6, 2021
|
|
||
| @Override | ||
| public int getStreamPosition() { | ||
| return -1; |
There was a problem hiding this comment.
Create a constant for this in CommentsInfoItem, something like NO_STREAM_POSITION
There was a problem hiding this comment.
Good idea 👍
I also added NO_LIKE_COUNT for comment likes
TobiGr
force-pushed
the
commentsStreamPosition
branch
from
1ad7f46
to
8497311
Compare
Stypox
approved these changes
Jun 6, 2021
SoundCloud is the only service which supports adding comments at a specific timestamp in the stream.
TobiGr
force-pushed
the
commentsStreamPosition
branch
from
8497311
to
f7f727d
Compare
This was referenced Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SoundCloud is the only service which supports adding comments at a specific timestamp in the stream.
Add
CommentsInfoItem.NO_LIKE_COUNTandCommentsInfoItem.NO_STREAM_POSITION.