Release 0.21.6 #6577
Comments
Merged
|
NOTE: Both bugs don't seem to appear after 12 hours of installation.
Bug ReportException
Crash log
Bug ReportException
Crash log
|
|
Some age-gated videos still tend to show error. Exception
Crash log
|
Indeed. The PR seems to have fixed some videos, but not all. |
|
NewPipe_v0.21.6_RC2.zip. @SameenAhnaf I was not able to reproduce your crashes. Did you import old feeds and bookmarks or did you create new ones? |
|
NewPipe_v0.21.6_RC3.zip fixes empty strings when using a Chinese localization. |
|
@TobiGr Import any other database (from 'Settings'>'Content') and you will begin to notice the bugs. EDIT: I noticed that the bug seems to persist only for a few hours after importing database. I found out some more bugs. These bugs tend to behave the same way.
Bug ReportException
Crash log
Bug ReportException
Crash log
|
|
After installing the app and importing my settings and subscriptions, refreshing my feed causes this exception. Exception
Crash log
|
|
Also when I don't import my settings and subscriptions, but rather add them manually, after refreshing the feed it says "Feed last updated: 4 minutes ago" rather than "Feed last updated: moments ago". |
That's probably because the default setting of "Feed Update threshold" is "5 minutes". Screenshot
|
|
@TobiGr How strange. RC3 doesn't install over RC1. Did the signing keys change? |
|
i took the builds from the CI. that's indeed strange. I'll look into it later. |
|
I think we should try to revert #5462 to fix the transaction problems (#6577 (comment), #6577 (comment)). From the
@TacoTheDank @Isira-Seneviratne What do you think? |
|
@SameenAhnaf Please test this APK and let me know if we fixed the database transaction crashes: transaction.zip |
|
@TobiGr Unfortunately, no. I tried to do following things.
I followed these steps to make sure that there's nothing wrong with my personal database. Also, the bugs seem to persist no matter if you import settings or not. |
|
I still cannot reproduce the bug, can you try this apk as well? room.zip |
|
@TobiGr I'd say that if trying to fix the issue starts to feel like more of a hassle than it's worth, then it would probably be better to just revert the change until we can find a better solution (at least so that it doesn't end up stalling the release process). |
|
Yeah this issue still persists.
It is happening n android 7 tablet. And is happening on this version as well Exception
Crash log
|
TobiGr
added a commit
that referenced
this issue
Jul 8, 2021
See #6577 (comment) java.lang.ClassCastException: android.widget.ImageButton cannot be cast to androidx.appcompat.widget.AppCompatImageButton at org.schabi.newpipe.player.Player.onRepeatModeChanged(Player.java:2263) at com.google.android.exoplayer2.ExoPlayerImpl.lambda$setRepeatMode$2(ExoPlayerImpl.java:564) at com.google.android.exoplayer2.-$$Lambda$ExoPlayerImpl$rgrcbaqP9Y8LgzdByBnAfUO4ydU.invokeListener(lambda) at com.google.android.exoplayer2.BasePlayer$ListenerHolder.invoke(BasePlayer.java:279) at com.google.android.exoplayer2.ExoPlayerImpl.invokeAll(ExoPlayerImpl.java:1498) at com.google.android.exoplayer2.ExoPlayerImpl.lambda$notifyListeners$6(ExoPlayerImpl.java:1318) at com.google.android.exoplayer2.-$$Lambda$ExoPlayerImpl$b59raXxaB-trjwE5bgpZInm1QnU.run(lambda) at com.google.android.exoplayer2.ExoPlayerImpl.notifyListeners(ExoPlayerImpl.java:1328) at com.google.android.exoplayer2.ExoPlayerImpl.notifyListeners(ExoPlayerImpl.java:1318) at com.google.android.exoplayer2.ExoPlayerImpl.setRepeatMode(ExoPlayerImpl.java:564) at com.google.android.exoplayer2.SimpleExoPlayer.setRepeatMode(SimpleExoPlayer.java:1636) at org.schabi.newpipe.player.Player.setRepeatMode(Player.java:2253) at org.schabi.newpipe.player.Player.onRepeatClicked(Player.java:2232) at org.schabi.newpipe.player.Player.onBroadcastReceived(Player.java:1123) at org.schabi.newpipe.player.Player.access$200(Player.java:190) at org.schabi.newpipe.player.Player$3.onReceive(Player.java:1060) at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:1185) ... 7 more
5 tasks
TobiGr
added a commit
that referenced
this issue
Jul 8, 2021
See #6577 (comment) java.lang.ClassCastException: android.widget.ImageButton cannot be cast to androidx.appcompat.widget.AppCompatImageButton at org.schabi.newpipe.player.Player.onRepeatModeChanged(Player.java:2263) at com.google.android.exoplayer2.ExoPlayerImpl.lambda$setRepeatMode$2(ExoPlayerImpl.java:564) at com.google.android.exoplayer2.-$$Lambda$ExoPlayerImpl$rgrcbaqP9Y8LgzdByBnAfUO4ydU.invokeListener(lambda) at com.google.android.exoplayer2.BasePlayer$ListenerHolder.invoke(BasePlayer.java:279) at com.google.android.exoplayer2.ExoPlayerImpl.invokeAll(ExoPlayerImpl.java:1498) at com.google.android.exoplayer2.ExoPlayerImpl.lambda$notifyListeners$6(ExoPlayerImpl.java:1318) at com.google.android.exoplayer2.-$$Lambda$ExoPlayerImpl$b59raXxaB-trjwE5bgpZInm1QnU.run(lambda) at com.google.android.exoplayer2.ExoPlayerImpl.notifyListeners(ExoPlayerImpl.java:1328) at com.google.android.exoplayer2.ExoPlayerImpl.notifyListeners(ExoPlayerImpl.java:1318) at com.google.android.exoplayer2.ExoPlayerImpl.setRepeatMode(ExoPlayerImpl.java:564) at com.google.android.exoplayer2.SimpleExoPlayer.setRepeatMode(SimpleExoPlayer.java:1636) at org.schabi.newpipe.player.Player.setRepeatMode(Player.java:2253) at org.schabi.newpipe.player.Player.onRepeatClicked(Player.java:2232) at org.schabi.newpipe.player.Player.onBroadcastReceived(Player.java:1123) at org.schabi.newpipe.player.Player.access$200(Player.java:190) at org.schabi.newpipe.player.Player$3.onReceive(Player.java:1060) at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:1185) ... 7 more
|
If your taking about this apk, then it doesn't work on this one |
|
I also get crashes after importing the database and refreshing feed: Exception
Crash log
And the second time I reloaded feed I got this: Exception
Crash log
Also for some reason all of my local playlists seem to be missing I also get errors on unsubscribing: Exception
Crash log
I will have time for investigating myself tomorrow afternoon |
|
I haven't encountered any crashes after importing my database. But I always close and reopen Newpipe after the import finishes. Are you guys doing the other actions without restarting Newpipe at least once when you encounter these crashes? |
|
@opusforlife2 I get all the errors below without restarting the app after import, but after restarting everything works smoothly. I always get this error on feed refresh (regardless of if it's the first time or not, and it happens close to the end of the refresh): ErrorException
Crash log
ErrorException
Crash log
ErrorException
Crash log
ErrorException
Crash log
|
|
Hopefully, restarting the app solves the bugs for me. But the app never misbehaved in the past. I am not sure if it is a standard practice to restart the app after applying every single setting. However, if such a bug is inevitable at this moment, 'Requires app restart to have app effect' subnote should be added. |
|
I compiled a test version without the changes from #6495. Please test if the database error is gone. |
|
Another test APK which (hopefully) fixed the bug introduced in #6495 without reverting the PR: app-debug.zip |
Thank you, I'm no longer getting any errors when refreshing my imported subscriptions. I did still having that issue I mentioned earlier when after refreshing it still doesn't say "Feed last updated: moments ago", in fact it says last updated 5 days ago which is when the database export was created. However simply restarting the app fixed it. |
Perfect! I opened #6639.
@el-banto Can you open a new issue describing the problem so we do not forget about it. I do not want to fix this issue in this release, because this is only a minor issue and the release process was already halted for too long. |
|
"What's new" Section BUG Steps to Reproduce:
|
|
@skyGtm I cannot reproduce that. Please give us some more info on your device and Android version |
|
Device: Huawei Nova 3i I will provide screen recording when possible. |
|
Has anyone had problems with lag? |
|
Cause it WAS a problem. Maybe we could ask the people on THAT issue whether it still persists |
Will do!
I have noticed this as well OS: Android 10 |
This comment has been minimized.
This comment has been minimized.
(If new videos are available) You have to manually scroll up to see the latest videos. abc.mp4@TobiGr here is the video Ingnore the video pattern change. I don't know why that happened Problem of Interest: After refresh: This was not an issue in v0.21.5 |
|
Why did the video pattern change? Strange |
|
The videos changing order seems to happen for videos which were released very close to each other (same hour or so). Perhaps the sorting is based on the hour? |
|
@skyGtm Thank you for the screencast. I am able to reproduce this now. I tried to fix this, but was just partly successful. This is only a minor regression. For this reason we'll proceed with releasing 0.21.6. Please open a new issue with the details from you two comments. I aim to fix this in the next version. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
APK for testing
From GitHub Actions: NewPipe_v0.21.6_RC3.zip
Please report only new bugs in this ticket. Corresponding PR: #6576
Changelogs
App
New
1- Long press on player share button to copy url to clipboard #6436
2- Added "Open website" button to WebView in license fragment #6314
9- Recognize timestamps and hashtags in description #5523
10- Added manual tablet mode setting #6059
11- Added ability to hide played items in a feed #3371
Improved
3- Support Storage Access Framework properly #5415
4- Better error handling of terminated channels #5876
5- Use constraint layout for play queue item #6443
12- The Android share sheet for Android 10+ users now shows the content title and other improvements #5523
20- Update Invidious instances and support Piped links #6557
Fixed
13- Dismiss choice dialog in onStop() to avoid a leaked window Exception: #6504
17- Don't enable SAF on Fire TV #6516
Development
6- Convert the abstract class DAOs to interfaces #5462
7- Resolve Tabs style checks #6346
8- Update Room to 2.3.0 #6313
14- Replace the System.exit calls with getActivity.finishAffinity() #6495
15- Update AndroidX Fragment to 1.3.4 #6394
16- Annotate some overridden methods and parameters as NonNull #6528
18- Refactoring by Android Studio #6556
19- Comment out test-android CI job #6562
21- Ask for screenshots/video of UI changes in PR template #6539
Extractor
New
1- Added
AccountTerminatedExceptionfor terminated channels TeamNewPipe/NewPipeExtractor#5802- [SoundCloud] Added
streamPositionfor comments TeamNewPipe/NewPipeExtractor#625Improved
9- Update Invidious instances and support Piped links TeamNewPipe/NewPipeExtractor#668
Fixed
3- [YouTube] Fix getting stream type of live streams TeamNewPipe/NewPipeExtractor#6585- [SoundCloud] Update HARDCODED_CLIENT_ID TeamNewPipe/NewPipeExtractor#660
10- [YouTube] Fix extraction of age restricted videos TeamNewPipe/NewPipeExtractor#665
Development
4- Add dependabot TeamNewPipe/NewPipeExtractor#552
6- Bump gson from 2.8.6 to 2.8.7 TeamNewPipe/NewPipeExtractor#654
7- Bump rhino from 1.7.12 to 1.7.13 TeamNewPipe/NewPipeExtractor#656
8- Bump spotbugs-annotations from 4.0.2 to 4.2.3 TeamNewPipe/NewPipeExtractor#655
The text was updated successfully, but these errors were encountered: