fix: set cluster field in metadata pipelines #2284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
cluster
metadata field was the only field set on the collector in Sumo, rather than in metadata pipelines. In the metadata pipelines, how it was handled varied a lot:The K8s metadata field that allows the k8s_tagger to set the cluster name is being deprecated in K8s upstream due to being actively confusing and not very useful. See: open-telemetry/opentelemetry-collector-contrib#9886 for more context, and also SumoLogic/sumologic-otel-collector#578.
Additionally, setting the field on the collector actually behaves subtly differently from sending it as a metric label, which caused one nasty bug for a client trialing OT.
This change explicitly sets the field based on the configuration value and removes it from the collector.
Checklist
Testing performed