Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8sclusterreceiver & k8sattributesreceiver no longer have ClusterName #9886

Closed
codeboten opened this issue May 9, 2022 · 4 comments
Closed

k8sclusterreceiver & k8sattributesreceiver no longer have ClusterName #9886

codeboten opened this issue May 9, 2022 · 4 comments
Assignees
@dmitryax

Comments

@codeboten
Copy link
Contributor

With recent changes to the k8s api, the ClusterName field has been removed. See the following change for more details:
6cdd63f

This field was reset by the system and never used as per: kubernetes/apimachinery@430b920#diff-35c0c434140e1c1254f58cc21b2f0ae371c7f2e00d15ce5d07da1b74c891ee97R257-R259

This issue is to determine whether there's additional work to be done or not.
@codeboten
Copy link
Contributor Author

@dmitryax assigned to you as a codeowner for both components. pinging @pmm-sumo as well

Please close this issue if the change implemented in the PR to update dependencies is good enough.

@pmm-sumo
Copy link
Contributor

Since #9885 was merged I am closing this now FYI @dmitryax

@pmm-sumo
Copy link
Contributor

pmm-sumo commented May 11, 2022 •
edited
Loading

Actually, I was too quick, there are some minor documentation/config updates, will take care of that

@pmm-sumo pmm-sumo reopened this May 11, 2022
@pmm-sumo pmm-sumo mentioned this issue May 11, 2022
Merged
@pmm-sumo
Copy link
Contributor

Closing via #9968

This was referenced May 18, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitryax dmitryax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codeboten @dmitryax @pmm-sumo