Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove mentions to distributed orchestrator mode #379

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

thbcmlowk
Copy link
Contributor

@thbcmlowk thbcmlowk commented Oct 18, 2023

Issue

Closes FL-1239

Description

Removed mentions to distributed orchestrator mode

Build

documentation/orchestrator/index.html

Related

Substra/orchestrator#319

@linear
Copy link

linear bot commented Oct 18, 2023

…ed mode

Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
@thbcmlowk thbcmlowk marked this pull request as ready for review October 19, 2023 10:03
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just update the changelog plz :)

@guilhem-barthes
Copy link
Contributor

Should we make an info-bubble in the doc mentioning this mode was available until version x.x.x so people coming from previous blogs / whitepapers won't be lost?

Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
@thbcmlowk
Copy link
Contributor Author

Looks good, just update the changelog plz :)

Thanks for the heads up. Updated

@thbcmlowk
Copy link
Contributor Author

Should we make an info-bubble in the doc mentioning this mode was available until version x.x.x so people coming from previous blogs / whitepapers won't be lost?

Great idea, thank you. Updated

Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Thanks !

@thbcmlowk thbcmlowk merged commit f200d04 into main Oct 24, 2023
3 checks passed
@thbcmlowk thbcmlowk deleted the chore/remove-distributed-orc branch October 24, 2023 08:31
thbcmlowk added a commit to Substra/orchestrator that referenced this pull request Oct 24, 2023
…319)

# Issue

FL-1237

# Description

* Removed `distributed` Skaffold profile and mentions in `README.md`
* Removed `chaincode-init` and `chaincode` docker images and workflows

## Checklist

- [x] [changelog](../CHANGELOG.md) was updated with notable changes
- [x] documentation was updated

## Needs

owkin/substra-ci#133
Substra/substra-documentation#379

## Related 

Substra/substra-backend#768

---------

Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants