Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(skaffold): remove distributed skaffold profile #768

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

thbcmlowk
Copy link
Contributor

@thbcmlowk thbcmlowk commented Oct 18, 2023

Issue

FL-1237

Description

  • Removed distributed Skaffold profile

Checklist

  • changelog was updated with notable changes
  • documentation was updated

Needs

https://github.com/owkin/substra-ci/pull/133
Substra/substra-documentation#379

Related

Substra/orchestrator#319

@linear
Copy link

linear bot commented Oct 18, 2023

@thbcmlowk thbcmlowk marked this pull request as ready for review October 18, 2023 09:38
@thbcmlowk thbcmlowk requested a review from a team as a code owner October 18, 2023 09:38
@thbcmlowk thbcmlowk force-pushed the chore/remove-distributed-skaffold branch from 1f9764f to 59db27b Compare October 19, 2023 09:54
@thbcmlowk
Copy link
Contributor Author

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Oct 19, 2023

End to end tests: ✔️ SUCCESS

@Substra Substra deleted a comment from Owlfred Oct 19, 2023
@thbcmlowk thbcmlowk changed the title chore(skaffold): remove distributed skaffold profile chore(skaffold): remove distributed skaffold profile Oct 19, 2023
thbcmlowk added a commit to Substra/orchestrator that referenced this pull request Oct 24, 2023
…319)

# Issue

FL-1237

# Description

* Removed `distributed` Skaffold profile and mentions in `README.md`
* Removed `chaincode-init` and `chaincode` docker images and workflows

## Checklist

- [x] [changelog](../CHANGELOG.md) was updated with notable changes
- [x] documentation was updated

## Needs

owkin/substra-ci#133
Substra/substra-documentation#379

## Related 

Substra/substra-backend#768

---------

Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
@thbcmlowk thbcmlowk force-pushed the chore/remove-distributed-skaffold branch from 59db27b to c90f527 Compare October 24, 2023 09:38
@thbcmlowk thbcmlowk merged commit b9459ac into main Oct 24, 2023
6 checks passed
@thbcmlowk thbcmlowk deleted the chore/remove-distributed-skaffold branch October 24, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants