Self host runner #3

SuZhou-Joe · 2023-09-07T03:47:09Z

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

add license header Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

Signed-off-by: Hailong Cui <ihailong@amazon.com>

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

* feat: add workspace creator page Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: integrate with application workspace template Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add max-width and remove image wrapper if not exists Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: update filter condition to align with collapsible nav Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: validation & query Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: modify file name to reduce confusion Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: add landing logic to retrive workspace id Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: add worklist observable Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: add worklist observable Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: add worklist observable Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * fix: type error Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * fix: type error Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: make client more robust Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: use Subject Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

* feat: integrate with workspace create API Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: update to i18n text for toast Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add currentWorkspace$ Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * fix: type error Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: add emit on currentWorkspace$ Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

Signed-off-by: Hailong Cui <ihailong@amazon.com>

Add workspace dropdown list --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com> Co-authored-by: SuZhoue-Joe <suzhou@amazon.com>

* feat: init workspace menu stage 1 Signed-off-by: tygao <tygao@amazon.com> * fix: remove port diff Signed-off-by: tygao <tygao@amazon.com> * feat: update menu logic Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>

* fix import error Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix osd bootstrap failure Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>

* feat: add workspace overview page Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: move paths to common constants Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add workspace overview item by custom nav in start phase Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: change to currentWorkspace$ in workspace client Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>

…rch-project#23) Signed-off-by: Lin Wang <wonglam@amazon.com>

fix failed test snapshots temporary fix: fetch functional test from main branch fixed git error which cannot find ref due to feature branch `workspace` not exists on repo opensearch-dashboards-functional-test Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

) * change to currentWorkspace, wrap title using i18n Signed-off-by: zhichao-aws <zhichaog@amazon.com> * change import Signed-off-by: zhichao-aws <zhichaog@amazon.com> * directly return [] if currentWorkspace is null Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com>

* feat: update workspace switch Signed-off-by: tygao <tygao@amazon.com> * fix: fix switch error Signed-off-by: tygao <tygao@amazon.com> * fix: fix prettier after merge Signed-off-by: tygao <tygao@amazon.com> * chore: remove extra code after merge Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* fix typo Signed-off-by: yuye-aws <yuyezhu@amazon.com> * adjust copy modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * list workspace with write permission on copy modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add copy icon and move getcopyworkspaces function from copy_modal to saved_object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix duplicate error in public workspace and change copy to duplicate all in header Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix: create saved objects in public workspace Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused import Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change validate schema Signed-off-by: yuye-aws <yuyezhu@amazon.com> * behavior subject bug fix for workspace plugin Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add workspace name duplication check Signed-off-by: Hailong Cui <ihailong@amazon.com> * update error message Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>

* hide workspace feature for management workspace settings Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add workspace settings to management workspace Signed-off-by: yuye-aws <yuyezhu@amazon.com> * prohibit name change for public and management workspace Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix empty permission bug Signed-off-by: yuye-aws <yuyezhu@amazon.com> * cancel export Signed-off-by: yuye-aws <yuyezhu@amazon.com> * position fix Signed-off-by: yuye-aws <yuyezhu@amazon.com> * make name text field readonly Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor render logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com>

…pensearch-project#127) Signed-off-by: tygao <tygao@amazon.com>

…arch-project#129) * cleanup: move WORKSPACE_TYPE constant to core/utils/constants Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

…h-project#124) * Revert "[Refractor] Feature flag (opensearch-project#102)" This reverts commit e2f277c.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

…roject#128) * feat: setup mechanism to register different implementation on query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some optimization on error message and response Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless clause Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move some code to a util function Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

…roject#126) Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

codecov-commenter · 2023-09-07T05:26:53Z

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (workspace@c6037d5). Click here to learn what that means.

❗ Current head 66baef1 differs from pull request most recent head 977e6a5. Consider uploading reports for the commit 977e6a5 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##             workspace       #3   +/-   ##
============================================
  Coverage             ?   66.80%           
============================================
  Files                ?     3285           
  Lines                ?    63176           
  Branches             ?    10076           
============================================
  Hits                 ?    42205           
  Misses               ?    18489           
  Partials             ?     2482

Flag	Coverage Δ
Linux_1	`35.26% <0.00%> (?)`
Linux_2	`55.34% <0.00%> (?)`
Linux_3	`43.84% <0.00%> (?)`
Linux_4	`35.36% <0.00%> (?)`
Windows_1	`35.28% <0.00%> (?)`
Windows_2	`55.31% <0.00%> (?)`
Windows_3	`43.84% <0.00%> (?)`
Windows_4	`35.36% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

This reverts commit fc24867.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

…objects client wrapper (opensearch-project#230) * feat: add basic workspace saved objects client wrapper Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add unit test (#2) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update client wrapper Signed-off-by: tygao <tygao@amazon.com> * feat: init permission control in workspace plugin Signed-off-by: Lin Wang <wonglam@amazon.com> * Support disable permission check on workspace (opensearch-project#228) * support disable permission check for workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix typos Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> * feat: add ACLSearchParams consumer in repository (#3) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: ACLSearchParams missing in search dsl Signed-off-by: Lin Wang <wonglam@amazon.com> * test: add integration test for workspace saved objects client wrapper Signed-off-by: Lin Wang <wonglam@amazon.com> * style: add empty line under license Signed-off-by: Lin Wang <wonglam@amazon.com> * test: enable workspace permission control for integration tests Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add workspace into includeHiddenTypes (opensearch-project#249) * feat: add workspace into includeHiddenTypes of client wrapper and permission control client Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: hiddenType side effect Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix workspace client wrapper integration tests Signed-off-by: Lin Wang <wonglam@amazon.com> * add permissions fields to workspace CRUD APIs Signed-off-by: Lin Wang <wonglam@amazon.com> * Move WorkspacePermissionMode inside workspace plugin Signed-off-by: Lin Wang <wonglam@amazon.com> * Address pr comments Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove ACLSearchParams in public SavedObjectsFindOptions Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove lodash and Add default permissionModes Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: address concerns on ensureRawRequest (#4) * feat: address concerns on ensureRawRequest Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add check for empty array Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make find api backward compatible Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Update annotations and error Signed-off-by: Lin Wang <wonglam@amazon.com> * Add unit tests for worksapce saved objects client wrapper Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove getPrincipalsOfObjects in permission Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix permissionEnabled flag missed in workspace plugin setup test Signed-off-by: Lin Wang <wonglam@amazon.com> * Change back to Not Authorized error Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix unit tests for query_params and plugin setup Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix unittests in workspace server utils Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add workspacesSearchOperators to decouple ACLSearchParams Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update test cases Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test cases Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: omit defaultSearchOperator in public savedobjetcs client Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: omit workspacesSearchOperator field Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Lin Wang <wonglam@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>

ruanyl and others added 30 commits August 3, 2023 17:21

setup workspace plugin project skeleton

912b6d2

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

test: add unit tests

b774c50

add license header Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

workspace template init commit

56a314c

Signed-off-by: Hailong Cui <ihailong@amazon.com>

refacter workspace template into hooks

327498c

Signed-off-by: Hailong Cui <ihailong@amazon.com>

refacter workspace template hooks

ff1645a

Signed-off-by: Hailong Cui <ihailong@amazon.com>

update coverImage comments

f1d0a35

Signed-off-by: Hailong Cui <ihailong@amazon.com>

feature: add public/workspaces service

168ba7f

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: add interfaces for workspaces client

7d3f24c

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: add interfaces for workspaces client

c6f9a47

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: add interfaces for workspaces client

e82777f

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: implement workspaces service

2c96331

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: changes to client type interface

5ec3feb

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: changes to client implement

0477076

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: implement more for workspaces service

0c07b79

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: implement more for workspaces service

7767933

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: implement more for workspaces service

ef1a245

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: use BehaviorObject and optimize code (#14)

a21d0c2

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

feat: integrate with workspace create API (#13)

e9b5c3b

* feat: integrate with workspace create API Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: update to i18n text for toast Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>

register plugin with workspace template (#16)

5074400

Signed-off-by: Hailong Cui <ihailong@amazon.com>

workspace dropdown list (#9)

cf16249

Add workspace dropdown list --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com> Co-authored-by: SuZhoue-Joe <suzhou@amazon.com>

Fix template registration import error (opensearch-project#21)

d7e740b

* fix import error Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix osd bootstrap failure Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>

feat: navigate to workspace create page after button clicked (opensea…

43c1bb6

…rch-project#23) Signed-off-by: Lin Wang <wonglam@amazon.com>

Hailong-am and others added 13 commits August 30, 2023 11:52

index pattern always show under library (opensearch-project#115)

081046e

Signed-off-by: Hailong Cui <ihailong@amazon.com>

add workspace name duplication check (opensearch-project#117)

f3a9672

* add workspace name duplication check Signed-off-by: Hailong Cui <ihailong@amazon.com> * update error message Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>

feat: remove workspace switch droplist and create workspace button (o…

2b9acb0

…pensearch-project#127) Signed-off-by: tygao <tygao@amazon.com>

Update backport.yml installation id

8802477

Revert "[Refractor] Feature flag (opensearch-project#102)" (opensearc…

58605a8

…h-project#124) * Revert "[Refractor] Feature flag (opensearch-project#102)" This reverts commit e2f277c.

fix: type import on WORKSPACE_TYPE (opensearch-project#131)

c6037d5

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

refactor: derive currentWorkspace in workspaces_service (opensearch-p…

56c8971

…roject#126) Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

feat: add self host runner

538fea9

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

7146b49

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

github-actions bot added the first-time-contributor label Sep 7, 2023

SuZhou-Joe added 10 commits September 8, 2023 17:08

feat: update

95a1ec8

feat: update

78f9f9c

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: use v4

fc24867

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

058c6ce

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

Revert "feat: use v4"

3b688de

This reverts commit fc24867.

feat: use auto-scaleable runners

9e08e89

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: use sudo

7a0840c

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

ec08c32

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

3a37711

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

977e6a5

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe force-pushed the workspace branch from afa373a to dc240eb Compare February 23, 2024 01:39

SuZhou-Joe added a commit that referenced this pull request Mar 1, 2024

feat: add ACLSearchParams consumer in repository (#3)

7d3086f

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe added a commit that referenced this pull request Mar 5, 2024

feat: add ACLSearchParams consumer in repository (#3)

48fea51

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Self host runner #3

Self host runner #3

SuZhou-Joe commented Sep 7, 2023 •

edited

Loading

codecov-commenter commented Sep 7, 2023 •

edited

Loading

Self host runner #3

Are you sure you want to change the base?

Self host runner #3

Conversation

SuZhou-Joe commented Sep 7, 2023 • edited Loading

Description

Issues Resolved

Check List

codecov-commenter commented Sep 7, 2023 • edited Loading

Codecov Report

SuZhou-Joe commented Sep 7, 2023 •

edited

Loading

codecov-commenter commented Sep 7, 2023 •

edited

Loading