Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] src/dev directory #128

Merged
merged 2 commits into from
Mar 12, 2021
Merged

[Rename] src/dev directory #128

merged 2 commits into from
Mar 12, 2021

Conversation

mihirsoni
Copy link
Contributor

Signed-off-by: Mihir Soni mihirsoni.123@gmail.com

Issue #, if available: #37

Description of changes: [Rename] src/dev directory

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes need to be check. Others look good.

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
@mihirsoni mihirsoni merged commit 3485842 into opensearch-project:dashboards Mar 12, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
* [Rename] src/dev directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] addressed review feedbacks

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
* [Rename] src/dev directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] addressed review feedbacks

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
mihirsoni added a commit that referenced this pull request Mar 20, 2021
* [Rename] src/dev directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] addressed review feedbacks

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 7, 2023
…roject#128)

* feat: setup mechanism to register different implementation on query DSL

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some optimization on error message and response

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: remove useless clause

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: move some code to a util function

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
…roject#128) (opensearch-project#135)

* feat: setup mechanism to register different implementation on query DSL



* feat: some optimization on error message and response



* feat: remove useless clause



* feat: move some code to a util function



---------


(cherry picked from commit 6d59211)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
…roject#128)

* feat: setup mechanism to register different implementation on query DSL

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some optimization on error message and response

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: remove useless clause

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: move some code to a util function

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants