Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating my fork #2

Merged
merged 3 commits into from
Oct 31, 2017
Merged

updating my fork #2

merged 3 commits into from
Oct 31, 2017

Commits on Oct 30, 2017

  1. Fix 3657 (#3739) 

    * Reorders MANIFEST.in

* Includes the translations dir in MANIFEST
    @baldoalessandro
    baldoalessandro authored and Grace Guo committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    1e18bfd View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2017

  1. Escape columns names for time grains - postgres (#3736)

    @ryanthegiantlion @mistercrunch
    ryanthegiantlion authored and mistercrunch committed Oct 31, 2017
    Configuration menu
    Copy the full SHA
    814b70f View commit details
    Browse the repository at this point in the history

  2. Fix has_table method (#3741) 

    Dialect's has_table method requires connection as the first argument, not engine (https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/engine/interfaces.py#L454). Instead, we can use engine's has_table method that handles the connection for us (https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/engine/base.py#L2141). Alternatively, we could call engine.dialect.has_table(engine.connect(), ...).
    @mxmzdlv @mistercrunch
    mxmzdlv authored and mistercrunch committed Oct 31, 2017
    Configuration menu
    Copy the full SHA
    5bc734b View commit details
    Browse the repository at this point in the history