New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating my fork #2

Merged

SpyderRivera merged 3 commits into SpyderRivera:master from apache:master

Oct 31, 2017

Owner

SpyderRivera commented Oct 31, 2017

No description provided.

baldoalessandro and others added 3 commits

October 30, 2017 11:26


          Fix 3657 (#3739)

1e18bfd

* Reorders MANIFEST.in

* Includes the translations dir in MANIFEST


          Escape columns names for time grains - postgres (#3736)

814b70f


          Fix has_table method (#3741)

5bc734b

Dialect's has_table method requires connection as the first argument, not engine (https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/engine/interfaces.py#L454). Instead, we can use engine's has_table method that handles the connection for us (https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/engine/base.py#L2141). Alternatively, we could call engine.dialect.has_table(engine.connect(), ...).

SpyderRivera merged commit 95b4032 into SpyderRivera:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet