Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProtocolClient not an AbstractContextManager #88

Closed
wants to merge 2 commits into from
Closed

ProtocolClient not an AbstractContextManager #88

wants to merge 2 commits into from

Conversation

Christian-B
Copy link
Member

No description provided.

@Christian-B Christian-B mentioned this pull request Oct 12, 2023
Merged
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same when pulling b546d77 on AbstractContextManager into 2fec4d0 on master.

@Christian-B
Copy link
Member Author

Github actions flake8 show this PR is wrong.

As it passes test it is likely dead code see:
#89

@Christian-B Christian-B deleted the AbstractContextManager branch October 13, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowleya rowleya rowleya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Christian-B @coveralls @rowleya