simplify AbstractContextManager #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractContextManager is used but not as expected.
The only class that overrides _context_entered (SQLiteDB) also overrides exist.
So in SQLiteDB enter and exit are now implemented directly
No class overirdes _context_exception_occurred so this method makes no sense.
Keeping a simplified AbstractContextManager is needed as Spalloc pass these around and there is not better definition / Abstract
Must be done after SpiNNakerManchester/SpiNNFrontEndCommon#1130
related work can be done before or after
SpiNNakerManchester/SpiNNMan#368
SpiNNakerManchester/spalloc#88