Fixes Smile-SA/elasticsuite#1223 and improves select statement #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbayet
reviewed
Dec 10, 2018
| 'qty' => 'stock_index.' . IndexStructure::QUANTITY, | ||
| ] | ||
| ); | ||
| ->from($tableName, [ |
There was a problem hiding this comment.
It will only work if you're only using the default stock :
- the table
inventory_stock_1is actually a view based on a join ofcataloginventory_stockandcatalog_product_entityso it does provide the product_id - any subsequent stock index table will only have columns
sku,quantityandis_salable
Performance loss due to the extra join is negligible if not non-existent if only using the default stock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1223 and improves select statement