Fixes Smile-SA/elasticsuite#1223 #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbayet
requested changes
Dec 10, 2018
There was a problem hiding this comment.
Note: You commit amend can push -f your changes to your branches.
Could you also be a bit more explicit in the commit message, something along the way of
- "Fixes [BUG] ES 2.7 M 2.3 InventoryData loads all products #1223 Avoid loading all products stock info"
- "Fixes [BUG] ES 2.7 M 2.3 InventoryData loads all products #1223 Prevent indexed data loss on multiple batch pages"
Thanks !
...asticsuite-catalog/Model/ResourceModel/Product/Indexer/Fulltext/Datasource/InventoryData.php
Outdated
Show resolved
Hide resolved
rbayet
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1223
On a side note; is there a specific reason for joining on SKU? The index table (
inventory_stock_x) does contain aproduct_idcolumn, no need to joincatalog_product_entity. Create a secondary pull request with the adjusted select statement #1225.