Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event marker support #306

Merged
merged 24 commits into from
Mar 2, 2024
Merged

Add event marker support #306

merged 24 commits into from
Mar 2, 2024

Conversation

shueja
Copy link
Collaborator

@shueja shueja commented Feb 1, 2024

No description provided.

@shueja shueja marked this pull request as draft February 1, 2024 17:53
Awesomeplayer165
Awesomeplayer165 reviewed Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@Awesomeplayer165 Awesomeplayer165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adding markers to the visibility toolbar on the side? it is getting a bit long however.

82419

@shueja shueja marked this pull request as ready for review February 29, 2024 02:12
calcmogul
calcmogul reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@calcmogul calcmogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI part worked for me at least. Took me a minute to realize I needed to click on the waypoint to add the marker. I assume this'll be addressed by docs later.

@calcmogul calcmogul changed the title Feature/event markers Add event marker support Mar 2, 2024
@calcmogul calcmogul merged commit b3f1155 into main Mar 2, 2024
26 checks passed
@calcmogul calcmogul deleted the feature/event-markers branch March 2, 2024 19:12
@calcmogul calcmogul mentioned this pull request Mar 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awesomeplayer165 Awesomeplayer165 Awesomeplayer165 left review comments

@calcmogul calcmogul calcmogul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shueja @calcmogul @Awesomeplayer165