Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Nexus repo + PreciousStones #2894

Merged
merged 3 commits into from
May 29, 2020
Merged

Fix issue with Nexus repo + PreciousStones #2894

merged 3 commits into from
May 29, 2020

Conversation

ShaneBeee
Copy link
Contributor

@ShaneBeee ShaneBeee commented Mar 29, 2020

Description

So it appears the nexus repo has gone down, which is causing builds to fail with PreciousStones.
For funsies, I took it out just to see what would happened, and the build started working. Goes to show this repo is not needed.

This PR is to fix said issue, so builds will start to build again.

Open for discussion :)


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@ShaneBeee ShaneBeee added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Mar 29, 2020
@ShaneBeee ShaneBeee requested a review from bensku March 29, 2020 06:21
@JRoy
Copy link
Contributor

JRoy commented Mar 29, 2020

Are you sure? It may be cached locally. Try removing your Gradle caches and see if it builds

@ShaneBeee
Copy link
Contributor Author

ShaneBeee commented Mar 29, 2020

Are you sure? It may be cached locally. Try removing your Gradle caches and see if it builds

The issue isn't building on my computer, thats always working, its the Java CI build that stopped working.

As you can see, all builds are failing now:
Screen Shot 2020-03-29 at 4 27 00 PM

@Wealthyturtle
Copy link
Member

Seems like this PR can be closed since the Nexus repo is back up. I requested a bunch of re-runs on the Java CI for other PRs and they passed.

@ShaneBeee
Copy link
Contributor Author

ah, ok, good to know its back up! I thought it was a goner.

@ShaneBeee ShaneBeee closed this Apr 2, 2020
@Wealthyturtle
Copy link
Member

Wealthyturtle commented May 29, 2020

Uhhh it's back again... should we merge this? @ShaneBeee #2664

@FranKusmiruk FranKusmiruk reopened this May 29, 2020
@FranKusmiruk FranKusmiruk merged commit 8c03475 into SkriptLang:master May 29, 2020
@ShaneBeee ShaneBeee deleted the test-branch-repo branch May 29, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants