Base Attributes

[Wealthyturtle]

Description

This PR is an improvement of #2656 that adds a new attributetype type and %entities%'s %attributetype% value expression, that allows for the direct modification of entities' attributes, such as attack speed attribute, max health attribute, etc. while also allowing for storage of attributetypes in variables.

Please help me review :)

---

Target Minecraft Versions: Any
Requirements: None
Related Issues: None

[FranKusmiruk]

The reason we have asked for a type is to be able to use the different enum constants as english phrases. Having an expression which uses a string is pretty much the same thing.

Look at how the Cat.Type or similar classes handle this behaviour.

[Wealthyturtle]

Ohhh sorry... Now I see what you mean... These few commits should fix that.

[Wealthyturtle]

By the way, is it alright for me to define all the attributes present in 1.14 in english.lang even if 2 of them did not exist in 1.9 (generic_armor_toughness & generic_flying_speed)?

[FranKusmiruk]

Yes, they're just ignored in older versions.

[Wealthyturtle]

Added a documentation notice that the movement speed attribute cannot be reliably used for players, and for that purpose, users should use the speed expression instead.

[bensku]

Could this be automatically tested, or does it require player interaction?

[Wealthyturtle]

@bensku We could probably do something like setting an entity's attribute, waiting a tick, and then comparing if it's the same as before.

[bensku]

Even waiting a tick should not be necessary. Besides, delays are currently not supported in tests.

[FranKusmiruk]

Is this ready for merge?

[Wealthyturtle]

Should be alright to merge. I can do a future PR to add more functionality onto this expression.

Changes were made